From b727d868fb93cca91f4609210c1aeb7becd8b763 Mon Sep 17 00:00:00 2001 From: cervantes Date: Wed, 18 Jan 2006 06:37:52 +0000 Subject: [PATCH] 2006-01-18 cervantes * Add title attributes to all external links in Syndie, so we can rollover and quickly see if it's worth clicking on. * Fixed a minor compiler warning. --- .../java/src/net/i2p/syndie/sml/BlogPostInfoRenderer.java | 3 ++- apps/syndie/java/src/net/i2p/syndie/sml/HTMLRenderer.java | 2 ++ .../java/src/net/i2p/syndie/sml/ThreadedHTMLRenderer.java | 1 + .../java/src/net/i2p/syndie/web/ViewBlogServlet.java | 2 +- history.txt | 7 ++++++- router/java/src/net/i2p/router/RouterVersion.java | 4 ++-- 6 files changed, 14 insertions(+), 5 deletions(-) diff --git a/apps/syndie/java/src/net/i2p/syndie/sml/BlogPostInfoRenderer.java b/apps/syndie/java/src/net/i2p/syndie/sml/BlogPostInfoRenderer.java index 1acf6a4d77..c179bad94f 100644 --- a/apps/syndie/java/src/net/i2p/syndie/sml/BlogPostInfoRenderer.java +++ b/apps/syndie/java/src/net/i2p/syndie/sml/BlogPostInfoRenderer.java @@ -232,7 +232,8 @@ public class BlogPostInfoRenderer extends EventReceiverImpl { out.append("schema=").append(HTMLRenderer.sanitizeURL(l.schema)).append("&"); if (l.location != null) out.append("location=").append(HTMLRenderer.sanitizeURL(l.location)).append("&"); - out.append("\">").append(HTMLRenderer.sanitizeString(l.location, 30)).append(" ("); + out.append("\" title=\"Goto ").append(HTMLRenderer.sanitizeTagParam(l.location)).append("\">"); + out.append(HTMLRenderer.sanitizeString(l.location, 30)).append(" ("); out.append(HTMLRenderer.sanitizeString(l.schema, 6)).append(")"); out.append("\n"); diff --git a/apps/syndie/java/src/net/i2p/syndie/sml/HTMLRenderer.java b/apps/syndie/java/src/net/i2p/syndie/sml/HTMLRenderer.java index c1d90428f0..c366fb55af 100644 --- a/apps/syndie/java/src/net/i2p/syndie/sml/HTMLRenderer.java +++ b/apps/syndie/java/src/net/i2p/syndie/sml/HTMLRenderer.java @@ -406,6 +406,7 @@ public class HTMLRenderer extends EventReceiverImpl { _bodyBuffer.append(sanitizeURL(schema)).append("&location="); _bodyBuffer.append(sanitizeURL(location)).append("&description="); _bodyBuffer.append(sanitizeURL(text)); + _bodyBuffer.append("\" title=\"Goto ").append(sanitizeTagParam(location)); _bodyBuffer.append("\">"). append(sanitizeString(text)). append(""); @@ -593,6 +594,7 @@ public class HTMLRenderer extends EventReceiverImpl { _postBodyBuffer.append("schema=").append(sanitizeURL(l.schema)).append('&'); if (l.location != null) _postBodyBuffer.append("location=").append(sanitizeURL(l.location)).append('&'); + _postBodyBuffer.append("\" title=\"Goto ").append(sanitizeTagParam(l.location)); _postBodyBuffer.append("\">").append(sanitizeString(l.location, 30)); _postBodyBuffer.append(getSpan("summDetailExternalNet")).append(" (").append(sanitizeString(l.schema)).append(") "); } diff --git a/apps/syndie/java/src/net/i2p/syndie/sml/ThreadedHTMLRenderer.java b/apps/syndie/java/src/net/i2p/syndie/sml/ThreadedHTMLRenderer.java index 123812ebc7..b543e1e6ee 100644 --- a/apps/syndie/java/src/net/i2p/syndie/sml/ThreadedHTMLRenderer.java +++ b/apps/syndie/java/src/net/i2p/syndie/sml/ThreadedHTMLRenderer.java @@ -428,6 +428,7 @@ public class ThreadedHTMLRenderer extends HTMLRenderer { _postBodyBuffer.append("schema=").append(sanitizeURL(l.schema)).append('&'); if (l.location != null) _postBodyBuffer.append("location=").append(sanitizeURL(l.location)).append('&'); + _postBodyBuffer.append("\" title=\"Goto ").append(sanitizeTagParam(l.location)); _postBodyBuffer.append("\">").append(sanitizeString(l.location, 30)); _postBodyBuffer.append(getSpan("summDetailExternalNet")).append(" (").append(sanitizeString(l.schema)).append(") "); } diff --git a/apps/syndie/java/src/net/i2p/syndie/web/ViewBlogServlet.java b/apps/syndie/java/src/net/i2p/syndie/web/ViewBlogServlet.java index 44fc76035e..8db5b2074d 100644 --- a/apps/syndie/java/src/net/i2p/syndie/web/ViewBlogServlet.java +++ b/apps/syndie/java/src/net/i2p/syndie/web/ViewBlogServlet.java @@ -603,8 +603,8 @@ public class ViewBlogServlet extends BaseServlet { } finally { try { in.close(); } catch (IOException ioe) {} try { out.close(); } catch (IOException ioe) {} - return true; } + return true; } } resp.setContentType("img.png"); diff --git a/history.txt b/history.txt index da76874bc7..8c97faa48f 100644 --- a/history.txt +++ b/history.txt @@ -1,4 +1,9 @@ -$Id: history.txt,v 1.390 2006/01/16 17:00:04 cervantes Exp $ +$Id: history.txt,v 1.391 2006/01/17 17:56:15 jrandom Exp $ + +2006-01-18 cervantes + * Add title attributes to all external links in Syndie, so we can rollover + and quickly see if it's worth clicking on. + * Fixed a minor compiler warning. 2006-01-17 jrandom * First pass of the new tunnel creation crypto, specified in the new diff --git a/router/java/src/net/i2p/router/RouterVersion.java b/router/java/src/net/i2p/router/RouterVersion.java index cd2cf01d4a..f01a5217e6 100644 --- a/router/java/src/net/i2p/router/RouterVersion.java +++ b/router/java/src/net/i2p/router/RouterVersion.java @@ -15,9 +15,9 @@ import net.i2p.CoreVersion; * */ public class RouterVersion { - public final static String ID = "$Revision: 1.334 $ $Date: 2006/01/14 15:14:47 $"; + public final static String ID = "$Revision: 1.335 $ $Date: 2006/01/17 17:56:16 $"; public final static String VERSION = "0.6.1.9"; - public final static long BUILD = 3; + public final static long BUILD = 4; public static void main(String args[]) { System.out.println("I2P Router version: " + VERSION + "-" + BUILD); System.out.println("Router ID: " + RouterVersion.ID);