From ff2d5badc9e99a2ad7bb3a271fdc258c044213c2 Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Fri, 19 Aug 2016 15:56:31 +0000
Subject: [PATCH] ReadConfigJob minor optimization

---
 .../src/net/i2p/router/tasks/ReadConfigJob.java     | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/router/java/src/net/i2p/router/tasks/ReadConfigJob.java b/router/java/src/net/i2p/router/tasks/ReadConfigJob.java
index 42391702a..8883957b6 100644
--- a/router/java/src/net/i2p/router/tasks/ReadConfigJob.java
+++ b/router/java/src/net/i2p/router/tasks/ReadConfigJob.java
@@ -24,11 +24,12 @@ import net.i2p.util.Log;
  * Unfortunately it will also read the file back in every time the
  * router writes it.
  *
- * So maybe this should just be disabled.
+ * We must keep this enabled, as it's the only way for people
+ * to set routerconsole.advanced=true without restarting.
  */
 public class ReadConfigJob extends JobImpl {
     private final static long DELAY = 30*1000; // reread every 30 seconds
-    private long _lastRead;
+    private volatile long _lastRead;
 
     public ReadConfigJob(RouterContext ctx) {
         super(ctx);
@@ -50,10 +51,8 @@ public class ReadConfigJob extends JobImpl {
     }
     
     private boolean shouldReread(File configFile) {
-        if (!configFile.exists()) return false;
-        if (configFile.lastModified() > _lastRead) 
-            return true;
-        else
-            return false;
+        // lastModified() returns 0 if not found
+        //if (!configFile.exists()) return false;
+        return configFile.lastModified() > _lastRead;
     }
 }