Add a date+time time-stamp to each snark message. #516

Open

marek wants to merge 1 commits from marek/i2p.i2p:snark_message_timestamp into master

pull from: marek/i2p.i2p:snark_message_timestamp

merge into: I2P_Developers:master

I2P_Developers:master

Conversation 6 Commits 1 Files Changed 1 +2 -1

marek commented 2025-06-12 11:10:13 -04:00

First-time contributor

Copy Link

#515

http://git.idk.i2p/I2P_Developers/i2p.i2p/issues/515

marek added 1 commit 2025-06-12 11:10:20 -04:00

Add a date+time time-stamp to each snark message. ... 2aa7379d91

#515

zzz commented 2025-06-12 11:35:13 -04:00

Owner

Copy Link

NACK

• Use DataHelper.formatTime() which is localized and in local time zone
• Don't reorder the imports

NACK - Use DataHelper.formatTime() which is localized and in local time zone - Don't reorder the imports

marek added 1 commit 2025-06-13 16:40:05 -04:00

Code review. ... 1e2470a87b

Use localized date time format instead of ISO-8601.
Do not reorder imports.

marek commented 2025-06-13 17:26:06 -04:00

Author

First-time contributor

Copy Link

NACK

• Use DataHelper.formatTime() which is localized and in local time zone
• Don't reorder the imports

Fixed.

> NACK > > - Use DataHelper.formatTime() which is localized and in local time zone > - Don't reorder the imports Fixed.

marek force-pushed snark_message_timestamp from 1e2470a87b to 32904f43c4 2025-06-22 00:02:42 -04:00 Compare

zzz commented 2025-06-24 11:03:22 -04:00

Owner

Copy Link

• move log.info() above where you add the timestamp, because the logger adds its own timestamps
• use internal time _context.clock().now() instead of System.currentTimeMillis()

still undecided if this is a good idea

- move log.info() above where you add the timestamp, because the logger adds its own timestamps - use internal time _context.clock().now() instead of System.currentTimeMillis() still undecided if this is a good idea

marek force-pushed snark_message_timestamp from 32904f43c4 to ec4a684458 2025-06-26 22:25:38 -04:00 Compare

marek commented 2025-06-26 22:29:47 -04:00

Author

First-time contributor

Copy Link

• move log.info() above where you add the timestamp, because the logger adds its own timestamps
• use internal time _context.clock().now() instead of System.currentTimeMillis()

Fixed.

still undecided if this is a good idea

The reason I think it is a good idea is described in #515 it says that: When I come to my snark the second day, I can see bunch of snark messages. But when did they happen? Few moments ago? During the night? Yesterday? I have no idea. Did I already read them? If they are from few days ago then probably yes, if they are from today then probably no. But I have no idea when they appeared.

> - move log.info() above where you add the timestamp, because the logger adds its own timestamps > - use internal time _context.clock().now() instead of System.currentTimeMillis() Fixed. > still undecided if this is a good idea The reason I think it is a good idea is described in http://git.idk.i2p/I2P_Developers/i2p.i2p/issues/515 it says that: When I come to my snark the second day, I can see bunch of snark messages. But when did they happen? Few moments ago? During the night? Yesterday? I have no idea. Did I already read them? If they are from few days ago then probably yes, if they are from today then probably no. But I have no idea when they appeared.

marek commented 2025-06-26 22:31:39 -04:00

Author

First-time contributor

Copy Link

Or, we could change the data structure holding the messages in a such way that it holds the timestamp and the message separately. So the user could decide in the settings whether they want to see the timestamp or not. (I want to see it.)

Or, we could change the data structure holding the messages in a such way that it holds the timestamp and the message separately. So the user could decide in the settings whether they want to see the timestamp or not. (I want to see it.)

zzz commented 2025-07-10 09:37:51 -04:00

Owner

Copy Link

I rarely want to resolve decisions by adding another config option that almost nobody will see or use.

I've been running snark with this patch for a couple weeks and IMHO it's more clutter than useful. I appreciate the contribution and that you did address my suggestions but as of now I'm leaning no.

I rarely want to resolve decisions by adding another config option that almost nobody will see or use. I've been running snark with this patch for a couple weeks and IMHO it's more clutter than useful. I appreciate the contribution and that you did address my suggestions but as of now I'm leaning no.

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u snark_message_timestamp:marek-snark_message_timestamp

git checkout marek-snark_message_timestamp

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

#1026

#1031

#1033

#1036

#1040

#1049

#1051

#1065

#1067

#1076

#1105

#1112

#1139

#1166

#1170

#1172

#1176

#1200

#1222

#1223

#1259

#1263

#1274

#1289

#1302

#1304

#1306

#1308

#1320

#1337

#1338

#1372

#1381

#1384

#1393

#1399

#1410

#1415

#1418

#1438

#1453

#1460

#1479

#1491

#1499

#1519

#1522

#1560

#1564

#1584

#1609

#1613

#1637

#1655

#1657

#1684

#1685

#1689

#1694

#1697

#1716

#1724

#1740

#1742

#1753

#1758

#1766

#1767

#1775

#1802

#1805

#1834

#1837

#1838

#1847

#1848

#1869

#1877

#1893

#1907

#1911

#1915

#1928

#1938

#1951

#1979

#1981

#1982

#1985

#1990

#1999

#2018

#2023

#2024

#2035

#2039

#2056

#2080

#2081

#2083

#2085

#2086

#2088

#2090

#2099

#2100

#2101

#2102

#2106

#2110

#2112

#2114

#2121

#2142

#2145

#2146

#2147

#2149

#2158

#2160

#2162

#2169

#2173

#2177

#2182

#2193

#2212

#2221

#2230

#2231

#2233

#2238

#2240

#2241

#2244

#2251

#2252

#2255

#2257

#2259

#2261

#2263

#2264

#2265

#2269

#2271

#2274

#2275

#2278

#2281

#2297

#23

#2302

#2303

#2304

#2305

#2306

#2309

#2319

#2323

#2324

#2325

#2336

#2337

#2340

#2341

#2346

#2350

#2363

#2371

#2374

#2375

#2376

#2381

#2386

#2393

#2396

#2402

#2411

#2420

#2421

#2426

#2428

#2429

#2431

#2433

#2434

#2446

#2459

#2467

#2472

#2475

#2496

#2497

#2506

#2509

#2512

#2540

#2562

#2572

#2608

#2609

#2613

#2619

#2620

#2625

#2640

#2641

#2642

#2643

#2646

#2647

#2650

#2653

#2655

#2656

#2658

#2660

#2664

#2670

#2672

#2675

#2680

#2681

#2682

#2689

#2690

#2691

#2695

#2700

#2701

#2703

#2704

#2705

#2707

#2711

#2721

#2729

#2730

#2733

#2734

#2735

#2736

#2737

#2738

#2750

#2751

#2754

#2763

#2764

#2766

#2771

#2772

#2773

#2774

#2775

#2780

#2782

#2792

#2793

#2795

#2796

#2799

#2801

#2802

#2803

#2805

#2807

#371

#374

#375

#376

#377

#378

#380

#381

#383

#384

#385

#386

#392

#44

#532

#629

#662

#666

#689

#691

#698

#699

#719

#725

#730

#731

#738

#745

#752

#774

#816

#818

#82

#829

#847

#857

#888

#933

#961

#971

#977

#981

0.9.18

0.9.20

0.9.21

0.9.23

0.9.24

0.9.25

0.9.27

0.9.28

0.9.29

0.9.30

0.9.31

0.9.32

0.9.33

0.9.35

0.9.36

0.9.37

0.9.38

0.9.39

0.9.42

0.9.43

0.9.45

0.9.46

0.9.47

0.9.48

0.9.49

0.9.50

0.9.9

BOB

I2CP

SAM

addressbook

api

apps

blocker

build

console

critical

crypto

data

debian

defect

docker

duplicate

easy-install bundle

enhancement

eventually

general

i2psnark

i2ptunnel

infrastructure

installer

jetty

maintenance

major

minor

misc

naming

netdb

not a bug

not our bug

package

profiles

research

router

soon

streaming

susidns

susimail

systray

task

tests

transport

trivial

tunnels

unconfirmed

undecided

update

utils

website

wontfix

works-for-me

wrapper

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

echelon idk zzz

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: I2P_Developers/i2p.i2p#516

Allow edits from maintainers

No description provided.