Release 0.4.16

README.md

@@ -4,11 +4,11 @@ MuWire is an easy to use file-sharing program which offers anonymity using [I2P
 
 It is inspired by the LimeWire Gnutella client and developped by a former LimeWire developer.
 
-The current stable release - 0.4.11 is avaiable for download at https://muwire.com.  You can find technical documentation in the "doc" folder.
+The current stable release - 0.4.15 is avaiable for download at https://muwire.com.  You can find technical documentation in the "doc" folder.
 
 ### Building
 
-You need JRE 8 or newer.  After installing that and setting up the appropriate paths, just type
+You need JDK 8 or newer.  After installing that and setting up the appropriate paths, just type
 
 ```
 ./gradlew clean assemble
@@ -19,13 +19,11 @@ If you want to run the unit tests, type
 ./gradlew clean build
 ```
 
-Some of the UI tests will fail because they haven't been written yet :-/
-
-If you want to build binary bundles for Windows and Mac that do not depend on Java or I2P, see the https://github.com/zlatinb/muwire-pkg project
+If you want to build binary bundles that do not depend on Java or I2P, see the https://github.com/zlatinb/muwire-pkg project
 
 ### Running
 
-After you build the application, look inside `gui/build/distributions`.  Untar/unzip one of the `shadow` files and then run the jar contained inside by typing `java -jar MuWire-x.y.z.jar` in a terminal or command prompt.
+After you build the application, look inside `gui/build/distributions`.  Untar/unzip one of the `shadow` files and then run the jar contained inside by typing `java -jar gui-x.y.z.jar` in a terminal or command prompt.
 
 If you have an I2P router running on the same machine that is all you need to do.  If you use a custom I2CP host and port, create a file `i2p.properties` and put `i2cp.tcp.host=<host>` and `i2cp.tcp.port=<port>` in there.  On Windows that file should go into `%HOME%\AppData\Roaming\MuWire`, on Mac into `$HOME/Library/Application Support/MuWire` and on Linux `$HOME/.MuWire`
 

TODO.md

@@ -23,6 +23,4 @@ To enable parsing of metadata from known file types and the user editing it or a
 ### Small Items
 
 * Wrapper of some kind for in-place upgrades
-* Download file sequentially
-* Multiple-selection download, Ctrl-A
 * Automatic adjustment of number of I2P tunnels

cli/src/main/groovy/com/muwire/cli/Cli.groovy

@@ -35,7 +35,7 @@ class Cli {
 
         Core core
         try {
-            core = new Core(props, home, "0.4.12")
+            core = new Core(props, home, "0.4.16")
         } catch (Exception bad) {
             bad.printStackTrace(System.out)
             println "Failed to initialize core, exiting"

cli/src/main/groovy/com/muwire/cli/CliDownloader.groovy

@@ -53,7 +53,7 @@ class CliDownloader {
 
         Core core
         try {
-            core = new Core(props, home, "0.4.12")
+            core = new Core(props, home, "0.4.16")
         } catch (Exception bad) {
             bad.printStackTrace(System.out)
             println "Failed to initialize core, exiting"

core/src/main/groovy/com/muwire/core/Constants.groovy

@@ -1,13 +0,0 @@
-package com.muwire.core
-
-import net.i2p.crypto.SigType
-
-class Constants {
-    public static final byte PERSONA_VERSION = (byte)1
-    public static final SigType SIG_TYPE = SigType.EdDSA_SHA512_Ed25519
-
-    public static final int MAX_HEADER_SIZE = 0x1 << 14
-    public static final int MAX_HEADERS = 16
-
-    public static final String SPLIT_PATTERN = "[\\*\\+\\-,\\.:;\\(\\)=_/\\\\\\!\\\"\\\'\\\$%\\|\\[\\]\\{\\}\\?]"
-}

core/src/main/groovy/com/muwire/core/Core.groovy

@@ -135,6 +135,7 @@ public class Core {
         } else {
             log.info("launching embedded router")
             Properties routerProps = new Properties()
+            routerProps.setProperty("i2p.dir.base", home.getAbsolutePath())
             routerProps.setProperty("i2p.dir.config", home.getAbsolutePath())
             routerProps.setProperty("router.excludePeerCaps", "KLM")
             routerProps.setProperty("i2np.inboundKBytesPerSecond", String.valueOf(props.inBw))
@@ -361,7 +362,7 @@ public class Core {
             }
         }
 
-        Core core = new Core(props, home, "0.4.12")
+        Core core = new Core(props, home, "0.4.16")
         core.startServices()
 
         // ... at the end, sleep or execute script

core/src/main/groovy/com/muwire/core/MuWireSettings.groovy

@@ -11,6 +11,7 @@ class MuWireSettings {
 
     final boolean isLeaf
     boolean allowUntrusted
+    boolean searchExtraHop
     boolean allowTrustLists
     int trustListInterval
     Set<Persona> trustSubscriptions
@@ -24,7 +25,7 @@ class MuWireSettings {
     boolean shareDownloadedFiles
     Set<String> watchedDirectories
     float downloadSequentialRatio
-    int hostClearInterval
+    int hostClearInterval, hostHopelessInterval, hostRejectInterval
     int meshExpiration
     boolean embeddedRouter
     int inBw, outBw
@@ -38,19 +39,22 @@ class MuWireSettings {
     MuWireSettings(Properties props) {
         isLeaf = Boolean.valueOf(props.get("leaf","false"))
         allowUntrusted = Boolean.valueOf(props.getProperty("allowUntrusted","true"))
+        searchExtraHop = Boolean.valueOf(props.getProperty("searchExtraHop","false"))
         allowTrustLists = Boolean.valueOf(props.getProperty("allowTrustLists","true"))
         trustListInterval = Integer.valueOf(props.getProperty("trustListInterval","1"))
         crawlerResponse = CrawlerResponse.valueOf(props.get("crawlerResponse","REGISTERED"))
         nickname = props.getProperty("nickname","MuWireUser")
         downloadLocation = new File((String)props.getProperty("downloadLocation",
             System.getProperty("user.home")))
-        downloadRetryInterval = Integer.parseInt(props.getProperty("downloadRetryInterval","1"))
+        downloadRetryInterval = Integer.parseInt(props.getProperty("downloadRetryInterval","60"))
         updateCheckInterval = Integer.parseInt(props.getProperty("updateCheckInterval","24"))
         autoDownloadUpdate = Boolean.parseBoolean(props.getProperty("autoDownloadUpdate","true"))
         updateType = props.getProperty("updateType","jar")
         shareDownloadedFiles = Boolean.parseBoolean(props.getProperty("shareDownloadedFiles","true"))
         downloadSequentialRatio = Float.valueOf(props.getProperty("downloadSequentialRatio","0.8"))
-        hostClearInterval = Integer.valueOf(props.getProperty("hostClearInterval","60"))
+        hostClearInterval = Integer.valueOf(props.getProperty("hostClearInterval","15"))
+        hostHopelessInterval = Integer.valueOf(props.getProperty("hostHopelessInterval", "1440"))
+        hostRejectInterval = Integer.valueOf(props.getProperty("hostRejectInterval", "1"))
         meshExpiration = Integer.valueOf(props.getProperty("meshExpiration","60"))
         embeddedRouter = Boolean.valueOf(props.getProperty("embeddedRouter","false"))
         inBw = Integer.valueOf(props.getProperty("inBw","256"))
@@ -74,6 +78,7 @@ class MuWireSettings {
         Properties props = new Properties()
         props.setProperty("leaf", isLeaf.toString())
         props.setProperty("allowUntrusted", allowUntrusted.toString())
+        props.setProperty("searchExtraHop", String.valueOf(searchExtraHop))
         props.setProperty("allowTrustLists", String.valueOf(allowTrustLists))
         props.setProperty("trustListInterval", String.valueOf(trustListInterval))
         props.setProperty("crawlerResponse", crawlerResponse.toString())
@@ -86,6 +91,8 @@ class MuWireSettings {
         props.setProperty("shareDownloadedFiles", String.valueOf(shareDownloadedFiles))
         props.setProperty("downloadSequentialRatio", String.valueOf(downloadSequentialRatio))
         props.setProperty("hostClearInterval", String.valueOf(hostClearInterval))
+        props.setProperty("hostHopelessInterval", String.valueOf(hostHopelessInterval))
+        props.setProperty("hostRejectInterval", String.valueOf(hostRejectInterval))
         props.setProperty("meshExpiration", String.valueOf(meshExpiration))
         props.setProperty("embeddedRouter", String.valueOf(embeddedRouter))
         props.setProperty("inBw", String.valueOf(inBw))

core/src/main/groovy/com/muwire/core/SplitPattern.groovy

@@ -0,0 +1,7 @@
+package com.muwire.core
+
+class SplitPattern {
+    
+    public static final String SPLIT_PATTERN = "[\\*\\+\\-,\\.:;\\(\\)=_/\\\\\\!\\\"\\\'\\\$%\\|\\[\\]\\{\\}\\?]";
+    
+}

core/src/main/groovy/com/muwire/core/connection/ConnectionEstablisher.groovy

@@ -31,7 +31,7 @@ class ConnectionEstablisher {
     final HostCache hostCache
 
     final Timer timer
-    final ExecutorService executor
+    final ExecutorService executor, closer
 
     final Set inProgress = new ConcurrentHashSet()
 
@@ -51,6 +51,8 @@ class ConnectionEstablisher {
             rv.setName("connector-${System.currentTimeMillis()}")
             rv
         } as ThreadFactory)
+        
+        closer = Executors.newSingleThreadExecutor()
     }
 
     void start() {
@@ -60,6 +62,7 @@ class ConnectionEstablisher {
     void stop() {
         timer.cancel()
         executor.shutdownNow()
+        closer.shutdown()
     }
 
     private void connectIfNeeded() {
@@ -120,8 +123,10 @@ class ConnectionEstablisher {
     }
 
     private void fail(Endpoint endpoint) {
-        endpoint.close()
-        eventBus.publish(new ConnectionEvent(endpoint: endpoint, incoming: false, leaf: false, status: ConnectionAttemptStatus.FAILED))
+        closer.execute {
+            endpoint.close()
+            eventBus.publish(new ConnectionEvent(endpoint: endpoint, incoming: false, leaf: false, status: ConnectionAttemptStatus.FAILED))
+        } as Runnable
     }
 
     private void readK(Endpoint e) {
@@ -175,7 +180,7 @@ class ConnectionEstablisher {
             log.log(Level.WARNING,"Problem parsing post-rejection payload",ignore)
         } finally {
             // the end
-            e.close()
+            closer.execute({e.close()} as Runnable)
         }
     }
 

core/src/main/groovy/com/muwire/core/download/DownloadManager.groovy

@@ -74,7 +74,7 @@ public class DownloadManager {
         destinations.addAll(e.sources)
         destinations.remove(me.destination)
 
-        Pieces pieces = getPieces(infohash, size, pieceSize)
+        Pieces pieces = getPieces(infohash, size, pieceSize, e.sequential)
 
         def downloader = new Downloader(eventBus, this, me, e.target, size,
             infohash, pieceSize, connector, destinations,
@@ -122,8 +122,12 @@ public class DownloadManager {
                 byte [] root = Base64.decode(json.hashRoot)
                 infoHash = new InfoHash(root)
             }
+            
+            boolean sequential = false
+            if (json.sequential != null)
+                sequential = json.sequential
 
-            Pieces pieces = getPieces(infoHash, (long)json.length, json.pieceSizePow2)
+            Pieces pieces = getPieces(infoHash, (long)json.length, json.pieceSizePow2, sequential)
 
             def downloader = new Downloader(eventBus, this, me, file, (long)json.length,
                 infoHash, json.pieceSizePow2, connector, destinations, incompletes, pieces)
@@ -137,12 +141,12 @@ public class DownloadManager {
         }
     }
 
-    private Pieces getPieces(InfoHash infoHash, long length, int pieceSizePow2) {
+    private Pieces getPieces(InfoHash infoHash, long length, int pieceSizePow2, boolean sequential) {
         int pieceSize = 0x1 << pieceSizePow2
         int nPieces = (int)(length / pieceSize)
         if (length % pieceSize != 0)
             nPieces++
-        Mesh mesh = meshManager.getOrCreate(infoHash, nPieces)
+        Mesh mesh = meshManager.getOrCreate(infoHash, nPieces, sequential)
         mesh.pieces
     }
 
@@ -188,6 +192,9 @@ public class DownloadManager {
                         json.hashRoot = Base64.encode(infoHash.getRoot())
 
                     json.paused = downloader.paused
+                    
+                    json.sequential = downloader.pieces.ratio == 0f
+                    
                     writer.println(JsonOutput.toJson(json))
                 }
             }

core/src/main/groovy/com/muwire/core/download/Pieces.groovy

@@ -17,7 +17,7 @@ class Pieces {
         done = new BitSet(nPieces)
         claimed = new BitSet(nPieces)
     }
-
+    
     synchronized int[] claim() {
         int claimedCardinality = claimed.cardinality()
         if (claimedCardinality == nPieces) {
@@ -30,7 +30,7 @@ class Pieces {
         }
 
         // if fuller than ratio just do sequential
-        if ( (1.0f * claimedCardinality) / nPieces > ratio) {
+        if ( (1.0f * claimedCardinality) / nPieces >= ratio) {
             int rv = claimed.nextClearBit(0)
             claimed.set(rv)
             return [rv, partials.getOrDefault(rv, 0), 0]
@@ -59,7 +59,8 @@ class Pieces {
             return [rv, partials.getOrDefault(rv, 0), 1]
         }
         List<Integer> toList = availableCopy.toList()
-        Collections.shuffle(toList)
+        if (ratio > 0f)
+            Collections.shuffle(toList)
         int rv = toList[0]
         claimed.set(rv)
         [rv, partials.getOrDefault(rv, 0), 0]

core/src/main/groovy/com/muwire/core/download/UIDownloadEvent.groovy

@@ -10,4 +10,5 @@ class UIDownloadEvent extends Event {
     UIResultEvent[] result
     Set<Destination> sources
     File target
+    boolean sequential
 }

core/src/main/groovy/com/muwire/core/files/PersisterService.groovy

@@ -46,7 +46,10 @@ class PersisterService extends Service {
     }
 
     void load() {
+        Thread.currentThread().setPriority(Thread.MIN_PRIORITY)
+
         if (location.exists() && location.isFile()) {
+            int loaded = 0
             def slurper = new JsonSlurper()
             try {
                 location.eachLine {
@@ -56,6 +59,9 @@ class PersisterService extends Service {
                         if (event != null) {
                             log.fine("loaded file $event.loadedFile.file")
                             listener.publish event
+                            loaded++
+                            if (loaded % 10 == 0)
+                                Thread.sleep(20)
                         }
                     }
                 }
@@ -109,11 +115,13 @@ class PersisterService extends Service {
             List sources = (List)json.sources
             Set<Destination> sourceSet = sources.stream().map({d -> new Destination(d.toString())}).collect Collectors.toSet()
             DownloadedFile df = new DownloadedFile(file, ih, pieceSize, sourceSet)
+            df.setComment(json.comment)
             return new FileLoadedEvent(loadedFile : df)
         }
 
 
         SharedFile sf = new SharedFile(file, ih, pieceSize)
+        sf.setComment(json.comment)
         return new FileLoadedEvent(loadedFile: sf)
 
     }
@@ -136,17 +144,13 @@ class PersisterService extends Service {
 
     private def toJson(File f, SharedFile sf) {
         def json = [:]
-        json.file = Base64.encode DataUtil.encodei18nString(f.toString())
+        json.file = sf.getB64EncodedFileName()
         json.length = sf.getCachedLength()
         InfoHash ih = sf.getInfoHash()
-        json.infoHash = Base64.encode ih.getRoot()
+        json.infoHash = sf.getB64EncodedHashRoot()
         json.pieceSize = sf.getPieceSize()
-        byte [] tmp = new byte [32]
-        json.hashList = []
-        for (int i = 0;i < ih.getHashList().length / 32; i++) {
-            System.arraycopy(ih.getHashList(), i * 32, tmp, 0, 32)
-            json.hashList.add Base64.encode(tmp)
-        }
+        json.hashList = sf.getB64EncodedHashList()
+        json.comment = sf.getComment()
 
         if (sf instanceof DownloadedFile) {
             json.sources = sf.sources.stream().map( {d -> d.toBase64()}).collect(Collectors.toList())

core/src/main/groovy/com/muwire/core/hostcache/Host.groovy

@@ -7,21 +7,35 @@ class Host {
     private static final int MAX_FAILURES = 3
 
     final Destination destination
-    private final int clearInterval
+    private final int clearInterval, hopelessInterval, rejectionInterval
     int failures,successes
     long lastAttempt
+    long lastSuccessfulAttempt
+    long lastRejection
 
-    public Host(Destination destination, int clearInterval) {
+    public Host(Destination destination, int clearInterval, int hopelessInterval, int rejectionInterval) {
         this.destination = destination
         this.clearInterval = clearInterval
+        this.hopelessInterval = hopelessInterval
+        this.rejectionInterval = rejectionInterval
     }
-
-    synchronized void onConnect() {
+    
+    private void connectSuccessful() {
         failures = 0
         successes++
         lastAttempt = System.currentTimeMillis()
     }
 
+    synchronized void onConnect() {
+        connectSuccessful()
+        lastSuccessfulAttempt = lastAttempt
+    }
+    
+    synchronized void onReject() {
+        connectSuccessful()
+        lastRejection = lastAttempt;
+    }
+
     synchronized void onFailure() {
         failures++
         successes = 0
@@ -40,7 +54,17 @@ class Host {
         failures = 0
     }
 
-    synchronized void canTryAgain() {
-        System.currentTimeMillis() - lastAttempt > (clearInterval * 60 * 1000)
+    synchronized boolean canTryAgain() {
+        lastSuccessfulAttempt > 0 && 
+            System.currentTimeMillis() - lastAttempt > (clearInterval * 60 * 1000)
+    }
+    
+    synchronized boolean isHopeless() {
+        isFailed() && 
+            System.currentTimeMillis() - lastSuccessfulAttempt > (hopelessInterval * 60 * 1000)
+    }
+    
+    synchronized boolean isRecentlyRejected() {
+        System.currentTimeMillis() - lastRejection < (rejectionInterval * 60 * 1000)
     }
 }

core/src/main/groovy/com/muwire/core/hostcache/HostCache.groovy

@@ -52,7 +52,7 @@ class HostCache extends Service {
             hosts.get(e.destination).clearFailures()
             return
         }
-        Host host = new Host(e.destination, settings.hostClearInterval)
+        Host host = new Host(e.destination, settings.hostClearInterval, settings.hostHopelessInterval, settings.hostRejectInterval)
         if (allowHost(host)) {
             hosts.put(e.destination, host)
         }
@@ -64,15 +64,17 @@ class HostCache extends Service {
         Destination dest = e.endpoint.destination
         Host host = hosts.get(dest)
         if (host == null) {
-            host = new Host(dest, settings.hostClearInterval)
+            host = new Host(dest, settings.hostClearInterval, settings.hostHopelessInterval, settings.hostRejectInterval)
             hosts.put(dest, host)
         }
 
         switch(e.status) {
             case ConnectionAttemptStatus.SUCCESSFUL:
-            case ConnectionAttemptStatus.REJECTED:
                 host.onConnect()
                 break
+            case ConnectionAttemptStatus.REJECTED:
+                host.onReject()
+                break
             case ConnectionAttemptStatus.FAILED:
                 host.onFailure()
                 break
@@ -82,6 +84,10 @@ class HostCache extends Service {
     List<Destination> getHosts(int n) {
         List<Destination> rv = new ArrayList<>(hosts.keySet())
         rv.retainAll {allowHost(hosts[it])}
+        rv.removeAll {
+            def h = hosts[it]; 
+            (h.isFailed() && !h.canTryAgain()) || h.isRecentlyRejected()
+        }
         if (rv.size() <= n)
             return rv
         Collections.shuffle(rv)
@@ -106,12 +112,16 @@ class HostCache extends Service {
             storage.eachLine {
                 def entry = slurper.parseText(it)
                 Destination dest = new Destination(entry.destination)
-                Host host = new Host(dest, settings.hostClearInterval)
+                Host host = new Host(dest, settings.hostClearInterval, settings.hostHopelessInterval, settings.hostRejectInterval)
                 host.failures = Integer.valueOf(String.valueOf(entry.failures))
                 host.successes = Integer.valueOf(String.valueOf(entry.successes))
                 if (entry.lastAttempt != null)
                     host.lastAttempt = entry.lastAttempt
-                if (allowHost(host))
+                if (entry.lastSuccessfulAttempt != null)
+                    host.lastSuccessfulAttempt = entry.lastSuccessfulAttempt
+                if (entry.lastRejection != null)
+                    host.lastRejection = entry.lastRejection
+                if (allowHost(host)) 
                     hosts.put(dest, host)
             }
         }
@@ -120,8 +130,6 @@ class HostCache extends Service {
     }
 
     private boolean allowHost(Host host) {
-        if (host.isFailed() && !host.canTryAgain())
-            return false
         if (host.destination == myself)
             return false
         TrustLevel trust = trustService.getLevel(host.destination)
@@ -140,12 +148,14 @@ class HostCache extends Service {
         storage.delete()
         storage.withPrintWriter { writer ->
             hosts.each { dest, host ->
-                if (allowHost(host)) {
+                if (allowHost(host) && !host.isHopeless()) {
                     def map = [:]
                     map.destination = dest.toBase64()
                     map.failures = host.failures
                     map.successes = host.successes
                     map.lastAttempt = host.lastAttempt
+                    map.lastSuccessfulAttempt = host.lastSuccessfulAttempt
+                    map.lastRejection = host.lastRejection
                     def json = JsonOutput.toJson(map)
                     writer.println json
                 }

core/src/main/groovy/com/muwire/core/mesh/MeshManager.groovy

@@ -33,11 +33,12 @@ class MeshManager {
         meshes.get(infoHash)
     }
 
-    Mesh getOrCreate(InfoHash infoHash, int nPieces) {
+    Mesh getOrCreate(InfoHash infoHash, int nPieces, boolean sequential) {
         synchronized(meshes) {
             if (meshes.containsKey(infoHash))
                 return meshes.get(infoHash)
-            Pieces pieces = new Pieces(nPieces, settings.downloadSequentialRatio)
+            float ratio = sequential ? 0f : settings.downloadSequentialRatio
+            Pieces pieces = new Pieces(nPieces, ratio)
             if (fileManager.rootToFiles.containsKey(infoHash)) {
                 for (int i = 0; i < nPieces; i++)
                     pieces.markDownloaded(i)

core/src/main/groovy/com/muwire/core/search/ResultsParser.groovy

@@ -90,6 +90,10 @@ class ResultsParser {
             Set<Destination> sources = Collections.emptySet()
             if (json.sources != null)
                 sources = json.sources.stream().map({new Destination(it)}).collect(Collectors.toSet())
+                
+            String comment = null
+            if (json.comment != null)
+                comment = DataUtil.readi18nString(Base64.decode(json.comment))
 
             return new UIResultEvent( sender : p,
                 name : name,
@@ -97,6 +101,7 @@ class ResultsParser {
                 infohash : new InfoHash(infoHash),
                 pieceSize : pieceSize,
                 sources : sources,
+                comment : comment,
                 uuid: uuid)
         } catch (Exception e) {
             throw new InvalidSearchResultException("parsing search result failed",e)

core/src/main/groovy/com/muwire/core/search/ResultsSender.groovy

@@ -121,6 +121,9 @@ class ResultsSender {
 
                         if (it instanceof DownloadedFile)
                             obj.sources = it.sources.stream().map({dest -> dest.toBase64()}).collect(Collectors.toSet())
+                            
+                        if (it.getComment() != null)
+                            obj.comment = it.getComment()
 
                         def json = jsonOutput.toJson(obj)
                         os.writeShort((short)json.length())

core/src/main/groovy/com/muwire/core/search/SearchIndex.groovy

@@ -1,6 +1,6 @@
 package com.muwire.core.search
 
-import com.muwire.core.Constants
+import com.muwire.core.SplitPattern
 
 class SearchIndex {
 
@@ -32,7 +32,7 @@ class SearchIndex {
     }
 
     private static String[] split(String source) {
-        source = source.replaceAll(Constants.SPLIT_PATTERN, " ").toLowerCase()
+        source = source.replaceAll(SplitPattern.SPLIT_PATTERN, " ").toLowerCase()
         String [] split = source.split(" ")
         def rv = []
         split.each { if (it.length() > 0) rv << it }

core/src/main/groovy/com/muwire/core/search/UIResultEvent.groovy

@@ -14,6 +14,7 @@ class UIResultEvent extends Event {
     long size
     InfoHash infohash
     int pieceSize
+    String comment
 
     @Override
     public String toString() {

core/src/main/groovy/com/muwire/core/upload/UploadManager.groovy

@@ -92,7 +92,7 @@ public class UploadManager {
                 pieceSize = downloader.pieceSizePow2
             } else {
                 SharedFile sharedFile = sharedFiles.iterator().next();
-                mesh = meshManager.getOrCreate(request.infoHash, sharedFile.NPieces)
+                mesh = meshManager.getOrCreate(request.infoHash, sharedFile.NPieces, false)
                 file = sharedFile.file
                 pieceSize = sharedFile.pieceSize
             }
@@ -217,7 +217,7 @@ public class UploadManager {
                 pieceSize = downloader.pieceSizePow2
             } else {
                 SharedFile sharedFile = sharedFiles.iterator().next();
-                mesh = meshManager.getOrCreate(request.infoHash, sharedFile.NPieces)
+                mesh = meshManager.getOrCreate(request.infoHash, sharedFile.NPieces, false)
                 file = sharedFile.file
                 pieceSize = sharedFile.pieceSize
             }

core/src/main/java/com/muwire/core/Constants.java

@@ -0,0 +1,11 @@
+package com.muwire.core;
+
+import net.i2p.crypto.SigType;
+
+public class Constants {
+    public static final byte PERSONA_VERSION = (byte)1;
+    public static final SigType SIG_TYPE = SigType.EdDSA_SHA512_Ed25519;
+
+    public static final int MAX_HEADER_SIZE = 0x1 << 14;
+    public static final int MAX_HEADERS = 16;
+}

core/src/main/java/com/muwire/core/SharedFile.java

@@ -2,6 +2,12 @@ package com.muwire.core;
 
 import java.io.File;
 import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+import com.muwire.core.util.DataUtil;
+
+import net.i2p.data.Base64;
 
 public class SharedFile {
 
@@ -11,6 +17,12 @@ public class SharedFile {
 
     private final String cachedPath;
     private final long cachedLength;
+    
+    private final String b64EncodedFileName;
+    private final String b64EncodedHashRoot;
+    private final List<String> b64EncodedHashList;
+    
+    private volatile String comment;
 
     public SharedFile(File file, InfoHash infoHash, int pieceSize) throws IOException {
         this.file = file;
@@ -18,6 +30,16 @@ public class SharedFile {
         this.pieceSize = pieceSize;
         this.cachedPath = file.getAbsolutePath();
         this.cachedLength = file.length();
+        this.b64EncodedFileName = Base64.encode(DataUtil.encodei18nString(file.toString()));
+        this.b64EncodedHashRoot = Base64.encode(infoHash.getRoot());
+        
+        List<String> b64List = new ArrayList<String>();
+        byte[] tmp = new byte[32];
+        for (int i = 0; i < infoHash.getHashList().length / 32; i++) {
+            System.arraycopy(infoHash.getHashList(), i * 32, tmp, 0, 32);
+            b64List.add(Base64.encode(tmp));
+        }
+        this.b64EncodedHashList = b64List;
     }
 
     public File getFile() {
@@ -40,6 +62,18 @@ public class SharedFile {
             rv++;
         return rv;
     }
+    
+    public String getB64EncodedFileName() {
+        return b64EncodedFileName;
+    }
+    
+    public String getB64EncodedHashRoot() {
+        return b64EncodedHashRoot;
+    }
+    
+    public List<String> getB64EncodedHashList() {
+        return b64EncodedHashList;
+    }
 
     public String getCachedPath() {
         return cachedPath;
@@ -48,6 +82,14 @@ public class SharedFile {
     public long getCachedLength() {
         return cachedLength;
     }
+    
+    public void setComment(String comment) {
+        this.comment = comment;
+    }
+    
+    public String getComment() {
+        return comment;
+    }
 
     @Override
     public int hashCode() {

core/src/main/java/com/muwire/core/util/DataUtil.java

@@ -1,122 +1,134 @@
-package com.muwire.core.util
+package com.muwire.core.util;
 
-import java.lang.reflect.Field
-import java.lang.reflect.Method
-import java.nio.ByteBuffer
-import java.nio.charset.StandardCharsets
+import java.io.ByteArrayOutputStream;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.lang.reflect.Field;
+import java.lang.reflect.Method;
+import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
+import java.util.List;
 
-import com.muwire.core.Constants
+import com.muwire.core.Constants;
 
-import net.i2p.data.Base64
+import net.i2p.data.Base64;
 
-class DataUtil {
+public class DataUtil {
 
-    private final static int MAX_SHORT = (0x1 << 16) - 1
+    private final static int MAX_SHORT = (0x1 << 16) - 1;
 
-    static void writeUnsignedShort(int value, OutputStream os) {
+    static void writeUnsignedShort(int value, OutputStream os) throws IOException {
         if (value > MAX_SHORT || value < 0)
-            throw new IllegalArgumentException("$value invalid")
+            throw new IllegalArgumentException("$value invalid");
 
-        byte lsb = (byte) (value & 0xFF)
-        byte msb = (byte) (value >> 8)
+        byte lsb = (byte) (value & 0xFF);
+        byte msb = (byte) (value >> 8);
 
-        os.write(msb)
-        os.write(lsb)
+        os.write(msb);
+        os.write(lsb);
     }
 
-    private final static int MAX_HEADER = 0x7FFFFF
+    private final static int MAX_HEADER = 0x7FFFFF;
 
     static void packHeader(int length, byte [] header) {
         if (header.length != 3)
-            throw new IllegalArgumentException("header length $header.length")
+            throw new IllegalArgumentException("header length $header.length");
         if (length < 0 || length > MAX_HEADER)
-            throw new IllegalArgumentException("length $length")
+            throw new IllegalArgumentException("length $length");
 
-        header[2] = (byte) (length & 0xFF)
-        header[1] = (byte) ((length >> 8) & 0xFF)
-        header[0] = (byte) ((length >> 16) & 0x7F)
+        header[2] = (byte) (length & 0xFF);
+        header[1] = (byte) ((length >> 8) & 0xFF);
+        header[0] = (byte) ((length >> 16) & 0x7F);
     }
 
     static int readLength(byte [] header) {
         if (header.length != 3)
-            throw new IllegalArgumentException("header length $header.length")
+            throw new IllegalArgumentException("header length $header.length");
 
         return (((int)(header[0] & 0x7F)) << 16) |
                 (((int)(header[1] & 0xFF) << 8)) |
-                ((int)header[2] & 0xFF)
+                ((int)header[2] & 0xFF);
     }
 
     static String readi18nString(byte [] encoded) {
         if (encoded.length < 2)
-            throw new IllegalArgumentException("encoding too short $encoded.length")
-        int length = ((encoded[0] & 0xFF) << 8) | (encoded[1] & 0xFF)
+            throw new IllegalArgumentException("encoding too short $encoded.length");
+        int length = ((encoded[0] & 0xFF) << 8) | (encoded[1] & 0xFF);
         if (encoded.length != length + 2)
-            throw new IllegalArgumentException("encoding doesn't match length, expected $length found $encoded.length")
-        byte [] string = new byte[length]
-        System.arraycopy(encoded, 2, string, 0, length)
-        new String(string, StandardCharsets.UTF_8)
+            throw new IllegalArgumentException("encoding doesn't match length, expected $length found $encoded.length");
+        byte [] string = new byte[length];
+        System.arraycopy(encoded, 2, string, 0, length);
+        return new String(string, StandardCharsets.UTF_8);
     }
 
-    static byte[] encodei18nString(String string) {
-        byte [] utf8 = string.getBytes(StandardCharsets.UTF_8)
+    public static byte[] encodei18nString(String string) {
+        byte [] utf8 = string.getBytes(StandardCharsets.UTF_8);
         if (utf8.length > Short.MAX_VALUE)
-            throw new IllegalArgumentException("String in utf8 too long $utf8.length")
-        def baos = new ByteArrayOutputStream()
-        def daos = new DataOutputStream(baos)
-        daos.writeShort((short) utf8.length)
-        daos.write(utf8)
-        daos.close()
-        baos.toByteArray()
+            throw new IllegalArgumentException("String in utf8 too long $utf8.length");
+        ByteArrayOutputStream baos = new ByteArrayOutputStream();
+        DataOutputStream daos = new DataOutputStream(baos);
+        try {
+            daos.writeShort((short) utf8.length);
+            daos.write(utf8);
+            daos.close();
+        } catch (IOException impossible) {
+            throw new IllegalStateException(impossible);
+        }
+        return baos.toByteArray();
     }
 
-    public static String readTillRN(InputStream is) {
-        def baos = new ByteArrayOutputStream()
+    public static String readTillRN(InputStream is) throws IOException {
+        ByteArrayOutputStream baos = new ByteArrayOutputStream();
         while(baos.size() < (Constants.MAX_HEADER_SIZE)) {
-            byte read = is.read()
+            int read = is.read();
             if (read == -1)
-                throw new IOException()
+                throw new IOException();
             if (read == '\r') {
                 if (is.read() != '\n')
-                    throw new IOException("invalid header")
-                break
+                    throw new IOException("invalid header");
+                break;
             }
-            baos.write(read)
+            baos.write(read);
         }
-        new String(baos.toByteArray(), StandardCharsets.US_ASCII)
+        return new String(baos.toByteArray(), StandardCharsets.US_ASCII);
     }
 
     public static String encodeXHave(List<Integer> pieces, int totalPieces) {
-        int bytes = totalPieces / 8
+        int bytes = totalPieces / 8;
         if (totalPieces % 8 != 0)
-            bytes++
-        byte[] raw = new byte[bytes]
-        pieces.each {
-            int byteIdx = it / 8
-            int offset = it % 8
-            int mask = 0x80 >>> offset
-            raw[byteIdx] |= mask
+            bytes++;
+        byte[] raw = new byte[bytes];
+        for (int it : pieces) {
+            int byteIdx = it / 8;
+            int offset = it % 8;
+            int mask = 0x80 >>> offset;
+            raw[byteIdx] |= mask;
         }
-        Base64.encode(raw)
+        return Base64.encode(raw);
     }
 
     public static List<Integer> decodeXHave(String xHave) {
-        byte [] availablePieces = Base64.decode(xHave)
-        List<Integer> available = new ArrayList<>()
-        availablePieces.eachWithIndex {b, i ->
+        byte [] availablePieces = Base64.decode(xHave);
+        List<Integer> available = new ArrayList<>();
+        for (int i = 0; i < availablePieces.length; i ++) {
+            byte b = availablePieces[i];
             for (int j = 0; j < 8 ; j++) {
-                byte mask = 0x80 >>> j
+                byte mask = (byte) (0x80 >>> j);
                 if ((b & mask) == mask) {
-                    available.add(i * 8 + j)
+                    available.add(i * 8 + j);
                 }
             }
         }
-        available
+        return available;
     }
 
-    public static Exception findRoot(Exception e) {
+    public static Throwable findRoot(Throwable e) {
         while(e.getCause() != null)
-            e = e.getCause()
-        e
+            e = e.getCause();
+        return e;
     }
 
     public static void tryUnmap(ByteBuffer cb) {

core/src/test/groovy/com/muwire/core/download/DownloadSessionTest.groovy

@@ -4,6 +4,7 @@ import static org.junit.Assert.fail
 
 import org.junit.After
 import org.junit.Before
+import org.junit.Ignore
 import org.junit.Test
 
 import com.muwire.core.EventBus
@@ -180,10 +181,11 @@ class DownloadSessionTest {
     }
 
     @Test
+    @Ignore // this needs to be rewritten with stealing in mind
     public void testSmallFileClaimed() {
         initSession(20, [0])
         long now = System.currentTimeMillis()
-        downloadThread.join(100)
+        downloadThread.join(150)
         assert 100 >= (System.currentTimeMillis() - now)
         assert !performed
         assert available.isEmpty()

core/src/test/groovy/com/muwire/core/download/PiecesTest.groovy

@@ -16,7 +16,7 @@ class PiecesTest {
     public void testSinglePiece() {
         pieces = new Pieces(1)
         assert !pieces.isComplete()
-        assert pieces.claim() == 0
+        assert pieces.claim() == [0,0,0]
         pieces.markDownloaded(0)
         assert pieces.isComplete()
     }
@@ -25,28 +25,28 @@ class PiecesTest {
     public void testTwoPieces() {
         pieces = new Pieces(2)
         assert !pieces.isComplete()
-        int piece = pieces.claim()
-        assert piece == 0 || piece == 1
-        pieces.markDownloaded(piece)
+        int[] piece = pieces.claim()
+        assert piece[0] == 0 || piece[0] == 1
+        pieces.markDownloaded(piece[0])
         assert !pieces.isComplete()
-        int piece2 = pieces.claim()
-        assert piece != piece2
-        pieces.markDownloaded(piece2)
+        int[] piece2 = pieces.claim()
+        assert piece[0] != piece2[0]
+        pieces.markDownloaded(piece2[0])
         assert pieces.isComplete()
     }
 
     @Test
     public void testClaimAvailable() {
         pieces = new Pieces(2)
-        int claimed = pieces.claim([0].toSet())
-        assert claimed == 0
-        assert -1 == pieces.claim([0].toSet())
+        int[] claimed = pieces.claim([0].toSet())
+        assert claimed == [0,0,0]
+        assert [0,0,1] == pieces.claim([0].toSet())
     }
 
     @Test
     public void testClaimNoneAvailable() {
         pieces = new Pieces(20)
-        int claimed = pieces.claim()
-        assert -1 == pieces.claim([claimed].toSet())
+        int[] claimed = pieces.claim()
+        assert [0,0,0] == pieces.claim(claimed.toSet())
     }
 }

core/src/test/groovy/com/muwire/core/hostcache/HostCacheTest.groovy

@@ -72,6 +72,9 @@ class HostCacheTest {
             TrustLevel.NEUTRAL
         }
         settingsMock.ignore.allowUntrusted { true }
+        settingsMock.ignore.getHostClearInterval { 0 }
+        settingsMock.ignore.getHostHopelessInterval { 0 }
+        settingsMock.ignore.getHostRejectInterval { 0 }
 
         initMocks()
 
@@ -91,6 +94,10 @@ class HostCacheTest {
             TrustLevel.DISTRUSTED
         }
 
+        settingsMock.ignore.getHostClearInterval { 0 }
+        settingsMock.ignore.getHostHopelessInterval { 0 }
+        settingsMock.ignore.getHostRejectInterval { 0 }
+        
         initMocks()
 
         cache.onHostDiscoveredEvent(new HostDiscoveredEvent(destination: destinations.dest1))
@@ -104,6 +111,9 @@ class HostCacheTest {
             TrustLevel.NEUTRAL
         }
         settingsMock.ignore.allowUntrusted { false }
+        settingsMock.ignore.getHostClearInterval { 0 }
+        settingsMock.ignore.getHostHopelessInterval { 0 }
+        settingsMock.ignore.getHostRejectInterval { 0 }
 
         initMocks()
 
@@ -123,6 +133,9 @@ class HostCacheTest {
         }
         trustMock.demand.getLevel{ d -> TrustLevel.TRUSTED }
         trustMock.demand.getLevel{ d -> TrustLevel.TRUSTED }
+        settingsMock.ignore.getHostClearInterval { 0 }
+        settingsMock.ignore.getHostHopelessInterval { 0 }
+        settingsMock.ignore.getHostRejectInterval { 0 }
 
         initMocks()
         cache.onHostDiscoveredEvent(new HostDiscoveredEvent(destination: destinations.dest1))
@@ -139,7 +152,15 @@ class HostCacheTest {
             assert d == destinations.dest1
             TrustLevel.TRUSTED
         }
+        trustMock.demand.getLevel { d ->
+            assert d == destinations.dest1
+            TrustLevel.TRUSTED
+        }
 
+        settingsMock.ignore.getHostClearInterval { 100 }
+        settingsMock.ignore.getHostHopelessInterval { 0 }
+        settingsMock.ignore.getHostRejectInterval { 0 }
+        
         initMocks()
         cache.onHostDiscoveredEvent(new HostDiscoveredEvent(destination: destinations.dest1))
 
@@ -158,6 +179,10 @@ class HostCacheTest {
             TrustLevel.TRUSTED
         }
 
+        settingsMock.ignore.getHostClearInterval { 0 }
+        settingsMock.ignore.getHostHopelessInterval { 0 }
+        settingsMock.ignore.getHostRejectInterval { 0 }
+        
         initMocks()
         cache.onHostDiscoveredEvent(new HostDiscoveredEvent(destination: destinations.dest1))
 
@@ -183,6 +208,10 @@ class HostCacheTest {
             TrustLevel.TRUSTED
         }
 
+        settingsMock.ignore.getHostClearInterval { 0 }
+        settingsMock.ignore.getHostHopelessInterval { 0 }
+        settingsMock.ignore.getHostRejectInterval { 0 }
+        
         initMocks()
         cache.onHostDiscoveredEvent(new HostDiscoveredEvent(destination: destinations.dest1))
 
@@ -214,6 +243,10 @@ class HostCacheTest {
             TrustLevel.TRUSTED
         }
 
+        settingsMock.ignore.getHostClearInterval { 0 }
+        settingsMock.ignore.getHostHopelessInterval { 0 }
+        settingsMock.ignore.getHostRejectInterval { 0 }
+        
         initMocks()
         cache.onHostDiscoveredEvent(new HostDiscoveredEvent(destination: destinations.dest1))
         cache.onHostDiscoveredEvent(new HostDiscoveredEvent(destination: destinations.dest1))
@@ -229,6 +262,11 @@ class HostCacheTest {
             assert d == destinations.dest1
             TrustLevel.TRUSTED
         }
+        
+        settingsMock.ignore.getHostClearInterval { 0 }
+        settingsMock.ignore.getHostHopelessInterval { 0 }
+        settingsMock.ignore.getHostRejectInterval { 0 }
+        
         initMocks()
         cache.onHostDiscoveredEvent(new HostDiscoveredEvent(destination: destinations.dest1))
         Thread.sleep(150)
@@ -260,6 +298,10 @@ class HostCacheTest {
             TrustLevel.TRUSTED
         }
 
+        settingsMock.ignore.getHostClearInterval { 0 }
+        settingsMock.ignore.getHostHopelessInterval { 0 }
+        settingsMock.ignore.getHostRejectInterval { 0 }
+        
         initMocks()
         def rv = cache.getHosts(5)
         assert rv.size() == 1

core/src/test/groovy/com/muwire/core/upload/UploaderTest.groovy

@@ -9,6 +9,9 @@ import org.junit.Test
 
 import com.muwire.core.InfoHash
 import com.muwire.core.connection.Endpoint
+import com.muwire.core.download.Pieces
+import com.muwire.core.files.FileHasher
+import com.muwire.core.mesh.Mesh
 
 class UploaderTest {
 
@@ -52,7 +55,13 @@ class UploaderTest {
     }
 
     private void startUpload() {
-        uploader = new ContentUploader(file, request, endpoint)
+        def hasher = new FileHasher()
+        InfoHash infoHash = hasher.hashFile(file)
+        Pieces pieces = new Pieces(FileHasher.getPieceSize(file.length()))
+        for (int i = 0; i < pieces.nPieces; i++)
+            pieces.markDownloaded(i)
+        Mesh mesh = new Mesh(infoHash, pieces)
+        uploader = new ContentUploader(file, request, endpoint, mesh, FileHasher.getPieceSize(file.length()))
         uploadThread = new Thread(uploader.respond() as Runnable)
         uploadThread.setDaemon(true)
         uploadThread.start()
@@ -81,6 +90,7 @@ class UploaderTest {
         startUpload()
         assert "200 OK" == readUntilRN()
         assert "Content-Range: 0-19" == readUntilRN()
+        assert readUntilRN().startsWith("X-Have")
         assert "" == readUntilRN()
 
         byte [] data = new byte[20]
@@ -96,6 +106,7 @@ class UploaderTest {
         startUpload()
         assert "200 OK" == readUntilRN()
         assert "Content-Range: 5-15" == readUntilRN()
+        assert readUntilRN().startsWith("X-Have")
         assert "" == readUntilRN()
 
         byte [] data = new byte[11]
@@ -111,6 +122,7 @@ class UploaderTest {
         request = new ContentRequest(range : new Range(0,20))
         startUpload()
         assert "416 Range Not Satisfiable" == readUntilRN()
+        assert readUntilRN().startsWith("X-Have")
         assert "" == readUntilRN()
     }
 
@@ -123,6 +135,7 @@ class UploaderTest {
         readUntilRN()
         readUntilRN()
         readUntilRN()
+        readUntilRN()
 
         byte [] data = new byte[length]
         DataInputStream dis = new DataInputStream(is)

gradle.properties

@@ -1,5 +1,5 @@
 group         = com.muwire
-version       = 0.4.12
+version       = 0.4.16
 groovyVersion = 2.4.15
 slf4jVersion  = 1.7.25
 spockVersion  = 1.1-groovy-2.4

gui/build.gradle

@@ -44,9 +44,9 @@ mainClassName = 'com.muwire.gui.Launcher'
 applicationDefaultJvmArgs = ['-Djava.util.logging.config.file=logging.properties']
 
 apply from: 'gradle/publishing.gradle'
-apply from: 'gradle/code-coverage.gradle'
-apply from: 'gradle/code-quality.gradle'
-apply from: 'gradle/integration-test.gradle'
+// apply from: 'gradle/code-coverage.gradle'
+// apply from: 'gradle/code-quality.gradle'
+// apply from: 'gradle/integration-test.gradle'
 // apply from: 'gradle/package.gradle'
 apply from: 'gradle/docs.gradle'
 apply plugin: 'com.github.johnrengelman.shadow'
@@ -119,6 +119,7 @@ if (hasProperty('debugRun') && ((project.debugRun as boolean))) {
     }
 }
 
+/*
 task jacocoRootMerge(type: org.gradle.testing.jacoco.tasks.JacocoMerge, dependsOn: [test, jacocoTestReport, jacocoIntegrationTestReport]) {
     executionData = files(jacocoTestReport.executionData, jacocoIntegrationTestReport.executionData)
     destinationFile = file("${buildDir}/jacoco/root.exec")
@@ -138,4 +139,5 @@ task jacocoRootReport(dependsOn: jacocoRootMerge, type: JacocoReport) {
         xml.destination = file("${buildDir}/reports/jacoco/root/root.xml")
     }
 }
+*/
 

gui/griffon-app/conf/Config.groovy

@@ -46,4 +46,14 @@ mvcGroups {
         view = 'com.muwire.gui.ContentPanelView'
         controller = 'com.muwire.gui.ContentPanelController'
     }
+    'show-comment' {
+        model = 'com.muwire.gui.ShowCommentModel'
+        view = 'com.muwire.gui.ShowCommentView'
+        controller = 'com.muwire.gui.ShowCommentController'
+    }
+    'add-comment' {
+        model = 'com.muwire.gui.AddCommentModel'
+        view = 'com.muwire.gui.AddCommentView'
+        controller = 'com.muwire.gui.AddCommentController'
+    }
 }

gui/griffon-app/controllers/com/muwire/gui/AddCommentController.groovy

@@ -0,0 +1,39 @@
+package com.muwire.gui
+
+import griffon.core.artifact.GriffonController
+import griffon.core.controller.ControllerAction
+import griffon.inject.MVCMember
+import griffon.metadata.ArtifactProviderFor
+import net.i2p.data.Base64
+
+import javax.annotation.Nonnull
+
+import com.muwire.core.util.DataUtil
+
+@ArtifactProviderFor(GriffonController)
+class AddCommentController {
+    @MVCMember @Nonnull
+    AddCommentModel model
+    @MVCMember @Nonnull
+    AddCommentView view
+
+    @ControllerAction
+    void save() {
+        String comment = view.textarea.getText()
+        if (comment.trim().length() == 0)
+            comment = null
+        else
+            comment = Base64.encode(DataUtil.encodei18nString(comment))
+        model.selectedFiles.each {
+            it.setComment(comment)
+        }
+        mvcGroup.parentGroup.view.builder.getVariable("shared-files-table").model.fireTableDataChanged()
+        cancel()
+    }
+    
+    @ControllerAction
+    void cancel() {
+        view.dialog.setVisible(false)
+        mvcGroup.destroy()
+    }
+}

gui/griffon-app/controllers/com/muwire/gui/ContentPanelController.groovy

@@ -68,6 +68,16 @@ class ContentPanelController {
         model.refresh()
     }
     
+    @ControllerAction
+    void clearHits() {
+        int selectedRule = view.getSelectedRule()
+        if (selectedRule < 0)
+            return
+        Matcher matcher = model.rules[selectedRule]
+        matcher.matches.clear()
+        model.refresh()
+    }
+    
     @ControllerAction
     void trust() {
         int selectedHit = view.getSelectedHit()

gui/griffon-app/controllers/com/muwire/gui/MainFrameController.groovy

@@ -13,10 +13,10 @@ import javax.annotation.Nonnull
 import javax.inject.Inject
 import javax.swing.JTable
 
-import com.muwire.core.Constants
 import com.muwire.core.Core
 import com.muwire.core.Persona
 import com.muwire.core.SharedFile
+import com.muwire.core.SplitPattern
 import com.muwire.core.download.Downloader
 import com.muwire.core.download.DownloadStartedEvent
 import com.muwire.core.download.UIDownloadCancelledEvent
@@ -80,13 +80,14 @@ class MainFrameController {
             searchEvent = new SearchEvent(searchHash : root, uuid : uuid, oobInfohash: true)
         } else {
             // this can be improved a lot
-            def replaced = search.toLowerCase().trim().replaceAll(Constants.SPLIT_PATTERN, " ")
+            def replaced = search.toLowerCase().trim().replaceAll(SplitPattern.SPLIT_PATTERN, " ")
             def terms = replaced.split(" ")
             def nonEmpty = []
             terms.each { if (it.length() > 0) nonEmpty << it }
             searchEvent = new SearchEvent(searchTerms : nonEmpty, uuid : uuid, oobInfohash: true)
         }
-        core.eventBus.publish(new QueryEvent(searchEvent : searchEvent, firstHop : true,
+        boolean firstHop = core.muOptions.allowUntrusted || core.muOptions.searchExtraHop
+        core.eventBus.publish(new QueryEvent(searchEvent : searchEvent, firstHop : firstHop,
             replyTo: core.me.destination, receivedOn: core.me.destination,
             originator : core.me))
     }
@@ -269,10 +270,23 @@ class MainFrameController {
     }
 
     void unshareSelectedFile() {
-        SharedFile sf = view.selectedSharedFile()
+        def sf = view.selectedSharedFiles()
         if (sf == null)
             return
-        core.eventBus.publish(new FileUnsharedEvent(unsharedFile : sf))
+        sf.each {  
+            core.eventBus.publish(new FileUnsharedEvent(unsharedFile : it))
+        }
+    }
+    
+    @ControllerAction
+    void addComment() {
+        def selectedFiles = view.selectedSharedFiles()
+        if (selectedFiles == null || selectedFiles.isEmpty())
+            return
+        
+        Map<String, Object> params = new HashMap<>()
+        params['selectedFiles'] = selectedFiles
+        mvcGroup.createMVCGroup("add-comment", "Add Comment", params)
     }
 
     void stopWatchingDirectory() {

gui/griffon-app/controllers/com/muwire/gui/OptionsController.groovy

@@ -96,6 +96,10 @@ class OptionsController {
         model.onlyTrusted = onlyTrusted
         settings.setAllowUntrusted(!onlyTrusted)
 
+        boolean searchExtraHop = view.searchExtraHopCheckbox.model.isSelected()
+        model.searchExtraHop = searchExtraHop
+        settings.searchExtraHop = searchExtraHop
+        
         boolean trustLists = view.allowTrustListsCheckbox.model.isSelected()
         model.trustLists = trustLists
         settings.allowTrustLists = trustLists

gui/griffon-app/controllers/com/muwire/gui/SearchTabController.groovy

@@ -8,63 +8,81 @@ import javax.annotation.Nonnull
 
 import com.muwire.core.Core
 import com.muwire.core.download.UIDownloadEvent
+import com.muwire.core.search.UIResultEvent
 import com.muwire.core.trust.TrustEvent
 import com.muwire.core.trust.TrustLevel
 
 @ArtifactProviderFor(GriffonController)
 class SearchTabController {
-    
+
     @MVCMember @Nonnull
     SearchTabModel model
     @MVCMember @Nonnull
     SearchTabView view
-    
+
     Core core
-    
-    private def selectedResult() {
-        int row = view.resultsTable.getSelectedRow()
-        if (row == -1)
+
+    private def selectedResults() {
+        int[] rows = view.resultsTable.getSelectedRows()
+        if (rows.length == 0)
             return null
         def sortEvt = view.lastSortEvent
         if (sortEvt != null) {
-            row = view.resultsTable.rowSorter.convertRowIndexToModel(row)
+            for (int i = 0; i < rows.length; i++) {
+                rows[i] = view.resultsTable.rowSorter.convertRowIndexToModel(rows[i])
+            }
+        }
+        List<UIResultEvent> results = new ArrayList<>()
+        rows.each { results.add(model.results[it]) }
+            results
         }
-        model.results[row]
-    }
-    
-    @ControllerAction
-    void download() {
-        def result = selectedResult()
-        if (result == null)
-            return
 
-        if (!mvcGroup.parentGroup.model.canDownload(result.infohash))
-            return
+        @ControllerAction
+        void download() {
+            def results = selectedResults()
+            if (results == null)
+                return
 
-        def file = new File(application.context.get("muwire-settings").downloadLocation, result.name)
+            results.removeAll {
+                !mvcGroup.parentGroup.model.canDownload(it.infohash)
+            }
 
-        def resultsBucket = model.hashBucket[result.infohash]
-        def sources = model.sourcesBucket[result.infohash]
+            results.each { result ->
+                def file = new File(application.context.get("muwire-settings").downloadLocation, result.name)
 
-        core.eventBus.publish(new UIDownloadEvent(result : resultsBucket, sources: sources, target : file))
-        mvcGroup.parentGroup.view.showDownloadsWindow.call()
-    }
+                def resultsBucket = model.hashBucket[result.infohash]
+                def sources = model.sourcesBucket[result.infohash]
 
-    @ControllerAction
-    void trust() {
-        int row = view.selectedSenderRow()
-        if (row < 0)
-            return 
-        def sender = model.senders[row]
-        core.eventBus.publish( new TrustEvent(persona : sender, level : TrustLevel.TRUSTED))
-    }
+                core.eventBus.publish(new UIDownloadEvent(result : resultsBucket, sources: sources,
+                target : file, sequential : view.sequentialDownloadCheckbox.model.isSelected()))
+            }
+            mvcGroup.parentGroup.view.showDownloadsWindow.call()
+        }
 
-    @ControllerAction
-    void distrust() {
-        int row = view.selectedSenderRow()
-        if (row < 0)
-            return 
-        def sender = model.senders[row] 
-        core.eventBus.publish( new TrustEvent(persona : sender, level : TrustLevel.DISTRUSTED))
-    }
-}
+        @ControllerAction
+        void trust() {
+            int row = view.selectedSenderRow()
+            if (row < 0)
+                return
+            def sender = model.senders[row]
+            core.eventBus.publish( new TrustEvent(persona : sender, level : TrustLevel.TRUSTED))
+        }
+
+        @ControllerAction
+        void distrust() {
+            int row = view.selectedSenderRow()
+            if (row < 0)
+                return
+            def sender = model.senders[row]
+            core.eventBus.publish( new TrustEvent(persona : sender, level : TrustLevel.DISTRUSTED))
+        }
+
+        @ControllerAction
+        void neutral() {
+            int row = view.selectedSenderRow()
+            if (row < 0)
+                return
+            def sender = model.senders[row]
+            core.eventBus.publish( new TrustEvent(persona : sender, level : TrustLevel.NEUTRAL))
+        }
+    }

gui/griffon-app/controllers/com/muwire/gui/ShowCommentController.groovy

@@ -0,0 +1,19 @@
+package com.muwire.gui
+
+import griffon.core.artifact.GriffonController
+import griffon.core.controller.ControllerAction
+import griffon.inject.MVCMember
+import griffon.metadata.ArtifactProviderFor
+import javax.annotation.Nonnull
+
+@ArtifactProviderFor(GriffonController)
+class ShowCommentController {
+    @MVCMember @Nonnull
+    ShowCommentView view
+
+    @ControllerAction
+    void dismiss() {
+        view.dialog.setVisible(false)
+        mvcGroup.destroy()
+    }
+}

gui/griffon-app/models/com/muwire/gui/AddCommentModel.groovy

@@ -0,0 +1,12 @@
+package com.muwire.gui
+
+import com.muwire.core.SharedFile
+
+import griffon.core.artifact.GriffonModel
+import griffon.transform.Observable
+import griffon.metadata.ArtifactProviderFor
+
+@ArtifactProviderFor(GriffonModel)
+class AddCommentModel {
+    List<SharedFile> selectedFiles
+}

gui/griffon-app/models/com/muwire/gui/ContentPanelModel.groovy

@@ -40,11 +40,15 @@ class ContentPanelModel {
     }
     
     void refresh() {
+        int selectedRule = view.getSelectedRule()
         rules.clear()
         rules.addAll(contentManager.matchers)
         hits.clear()
         view.rulesTable.model.fireTableDataChanged()
         view.hitsTable.model.fireTableDataChanged()
+        if (selectedRule >= 0) {
+            view.rulesTable.selectionModel.setSelectionInterval(selectedRule,selectedRule)
+        }
     }
     
     void onContentControlEvent(ContentControlEvent e) {

gui/griffon-app/models/com/muwire/gui/MainFrameModel.groovy

@@ -81,6 +81,7 @@ class MainFrameModel {
     @Observable boolean pauseButtonEnabled
     @Observable boolean clearButtonEnabled
     @Observable String resumeButtonText
+    @Observable boolean addCommentButtonEnabled
     @Observable boolean subscribeButtonEnabled
     @Observable boolean markNeutralFromTrustedButtonEnabled
     @Observable boolean markDistrustedButtonEnabled
@@ -109,7 +110,12 @@ class MainFrameModel {
     void updateTablePreservingSelection(String tableName) {
         def downloadTable = builder.getVariable(tableName)
         int selectedRow = downloadTable.getSelectedRow()
-        downloadTable.model.fireTableDataChanged()
+        while(true) {
+            try {
+                downloadTable.model.fireTableDataChanged()
+                break
+            } catch (IllegalArgumentException iae) {} // caused by underlying model changing while table is sorted
+        }
         downloadTable.selectionModel.setSelectionInterval(selectedRow,selectedRow)
     }
 
@@ -191,7 +197,7 @@ class MainFrameModel {
                     return
                 int retryInterval = core.muOptions.downloadRetryInterval
                 if (retryInterval > 0) {
-                    retryInterval *= 60000
+                    retryInterval *= 1000
                     long now = System.currentTimeMillis()
                     if (now - lastRetryTime > retryInterval) {
                         lastRetryTime = now
@@ -207,7 +213,7 @@ class MainFrameModel {
 
                     }
                 }
-            }, 60000, 60000)
+            }, 1000, 1000)
 
             runInsideUIAsync {
                 trusted.addAll(core.trustService.good.values())

gui/griffon-app/models/com/muwire/gui/OptionsModel.groovy

@@ -38,6 +38,7 @@ class OptionsModel {
 
     // trust options
     @Observable boolean onlyTrusted
+    @Observable boolean searchExtraHop
     @Observable boolean trustLists
     @Observable String trustListInterval
 
@@ -73,6 +74,7 @@ class OptionsModel {
         }
 
         onlyTrusted = !settings.allowUntrusted()
+        searchExtraHop = settings.searchExtraHop
         trustLists = settings.allowTrustLists
         trustListInterval = String.valueOf(settings.trustListInterval)
     }

gui/griffon-app/models/com/muwire/gui/ShowCommentModel.groovy

@@ -0,0 +1,12 @@
+package com.muwire.gui
+
+import com.muwire.core.search.UIResultEvent
+
+import griffon.core.artifact.GriffonModel
+import griffon.transform.Observable
+import griffon.metadata.ArtifactProviderFor
+
+@ArtifactProviderFor(GriffonModel)
+class ShowCommentModel {
+    UIResultEvent result
+}

gui/griffon-app/views/com/muwire/gui/AddCommentView.groovy

@@ -0,0 +1,68 @@
+package com.muwire.gui
+
+import griffon.core.artifact.GriffonView
+import griffon.inject.MVCMember
+import griffon.metadata.ArtifactProviderFor
+import net.i2p.data.Base64
+
+import javax.swing.JDialog
+import javax.swing.SwingConstants
+
+import com.muwire.core.util.DataUtil
+
+import java.awt.BorderLayout
+import java.awt.event.WindowAdapter
+import java.awt.event.WindowEvent
+
+import javax.annotation.Nonnull
+
+@ArtifactProviderFor(GriffonView)
+class AddCommentView {
+    @MVCMember @Nonnull
+    FactoryBuilderSupport builder
+    @MVCMember @Nonnull
+    AddCommentModel model
+
+    def mainFrame
+    def dialog
+    def p
+    def textarea
+    
+    void initUI() {
+        mainFrame = application.windowManager.findWindow("main-frame")
+        String title = "Add comment to multiple files"
+        String comment = ""
+        if (model.selectedFiles.size() == 1) {
+            title = "Add comments to " + model.selectedFiles[0].getFile().getName()
+            if (model.selectedFiles[0].comment != null)
+                comment = DataUtil.readi18nString(Base64.decode(model.selectedFiles[0].comment))
+        }
+        dialog = new JDialog(mainFrame, title, true)
+        
+        p = builder.panel {
+            borderLayout()
+            panel (constraints : BorderLayout.CENTER) {
+                scrollPane {
+                    textarea = textArea(text : comment, rows : 20, columns : 100, editable : true)
+                }
+            }
+            panel (constraints : BorderLayout.SOUTH) {
+                button(text : "Save", saveAction)
+                button(text : "Cancel", cancelAction)
+            }
+        }
+    }
+    
+    void mvcGroupInit(Map<String,String> args) {
+        dialog.getContentPane().add(p)
+        dialog.pack()
+        dialog.setLocationRelativeTo(mainFrame)
+        dialog.setDefaultCloseOperation(JDialog.DISPOSE_ON_CLOSE)
+        dialog.addWindowListener( new WindowAdapter() {
+            public void windowClosed(WindowEvent e) {
+                mvcGroup.destroy()
+            }
+        })
+        dialog.show()
+    }
+}

gui/griffon-app/views/com/muwire/gui/ContentPanelView.groovy

@@ -84,6 +84,7 @@ class ContentPanelView {
                 }
                 panel (constraints : BorderLayout.SOUTH) {
                     button(text : "Refresh", refreshAction)
+                    button(text : "Clear Hits", clearHitsAction)
                     button(text : "Trust", enabled : bind {model.trustButtonsEnabled}, trustAction)
                     button(text : "Distrust", enabled : bind {model.trustButtonsEnabled}, distrustAction)
                 }

gui/griffon-app/views/com/muwire/gui/MainFrameView.groovy

@@ -18,11 +18,13 @@ import javax.swing.JSplitPane
 import javax.swing.JTable
 import javax.swing.ListSelectionModel
 import javax.swing.SwingConstants
+import javax.swing.TransferHandler
 import javax.swing.border.Border
 import javax.swing.table.DefaultTableCellRenderer
 
 import com.muwire.core.Constants
 import com.muwire.core.MuWireSettings
+import com.muwire.core.SharedFile
 import com.muwire.core.download.Downloader
 import com.muwire.core.files.FileSharedEvent
 import com.muwire.core.trust.RemoteTrustList
@@ -33,6 +35,7 @@ import java.awt.GridBagConstraints
 import java.awt.GridBagLayout
 import java.awt.Insets
 import java.awt.Toolkit
+import java.awt.datatransfer.DataFlavor
 import java.awt.datatransfer.StringSelection
 import java.awt.event.MouseAdapter
 import java.awt.event.MouseEvent
@@ -62,7 +65,7 @@ class MainFrameView {
             application(size : [1024,768], id: 'main-frame',
             locationRelativeTo : null,
             title: application.configuration['application.title'] + " " +
-                metadata["application.version"] + " revision " + metadata["build.revision"],
+            metadata["application.version"] + " revision " + metadata["build.revision"],
             iconImage:   imageIcon('/MuWire-48x48.png').image,
             iconImages: [imageIcon('/MuWire-48x48.png').image,
                 imageIcon('/MuWire-32x32.png').image,
@@ -99,7 +102,7 @@ class MainFrameView {
                     panel(id: "top-panel", constraints: BorderLayout.CENTER) {
                         cardLayout()
                         label(constraints : "top-connect-panel",
-                            text : "        MuWire is connecting, please wait.  You will be able to search soon.") // TODO: real padding
+                        text : "        MuWire is connecting, please wait.  You will be able to search soon.") // TODO: real padding
                         panel(constraints : "top-search-panel") {
                             borderLayout()
                             panel(constraints: BorderLayout.CENTER) {
@@ -158,8 +161,8 @@ class MainFrameView {
                                         panel(constraints : "download-selected") {
                                             gridBagLayout()
                                             label(text : "Download Location:", constraints : gbc(gridx:0, gridy:0))
-                                            label(text : bind {model.downloader?.file?.getAbsolutePath()}, 
-                                                constraints: gbc(gridx:1, gridy:0, gridwidth: 2, insets : [0,0,0,20]))
+                                            label(text : bind {model.downloader?.file?.getAbsolutePath()},
+                                            constraints: gbc(gridx:1, gridy:0, gridwidth: 2, insets : [0,0,0,20]))
                                             label(text : "Piece Size", constraints : gbc(gridx: 0, gridy:1))
                                             label(text : bind {model.downloader?.pieceSize}, constraints : gbc(gridx:1, gridy:1))
                                             label(text : "Known Sources:", constraints : gbc(gridx:3, gridy: 0))
@@ -182,12 +185,12 @@ class MainFrameView {
                             borderLayout()
                             panel (constraints : BorderLayout.NORTH) {
                                 label(text : bind {
-                                        if (model.hashingFile == null) {
-                                            ""
-                                        } else {
-                                            "hashing: " + model.hashingFile.getAbsolutePath() + " (" + DataHelper.formatSize2Decimal(model.hashingFile.length(), false).toString() + "B)"
-                                        }
-                                    })
+                                    if (model.hashingFile == null) {
+                                        "You can drag-and-drop files and directories here"
+                                    } else {
+                                        "hashing: " + model.hashingFile.getAbsolutePath() + " (" + DataHelper.formatSize2Decimal(model.hashingFile.length(), false).toString() + "B)"
+                                    }
+                                })
                             }
                             panel (border : etchedBorder(), constraints : BorderLayout.CENTER) {
                                 gridLayout(cols : 2, rows : 1)
@@ -208,6 +211,7 @@ class MainFrameView {
                                             tableModel(list : model.shared) {
                                                 closureColumn(header : "Name", preferredWidth : 500, type : String, read : {row -> row.getCachedPath()})
                                                 closureColumn(header : "Size", preferredWidth : 100, type : Long, read : {row -> row.getCachedLength() })
+                                                closureColumn(header : "Comments", preferredWidth : 100, type : Boolean, read : {it.getComment() != null})
                                             }
                                         }
                                     }
@@ -220,8 +224,14 @@ class MainFrameView {
                                     button(text : "Share files", actionPerformed : shareFiles)
                                 }
                                 panel {
-                                    label("Shared:")
-                                    label(text : bind {model.loadedFiles.toString()})
+                                    gridLayout(rows : 1, cols : 2)
+                                    panel {
+                                        label("Shared:")
+                                        label(text : bind {model.loadedFiles.toString()})
+                                    }
+                                    panel {
+                                        button(text : "Add Comment", enabled : bind {model.addCommentButtonEnabled}, addCommentAction)
+                                    }
                                 }
                             }
                         }
@@ -305,8 +315,8 @@ class MainFrameView {
                                         })
                                         closureColumn(header : "Timestamp", type : String, read : {
                                             String.format("%02d", it.timestamp.get(Calendar.HOUR_OF_DAY)) + ":" +
-                                            String.format("%02d", it.timestamp.get(Calendar.MINUTE)) + ":" +
-                                            String.format("%02d", it.timestamp.get(Calendar.SECOND))
+                                                    String.format("%02d", it.timestamp.get(Calendar.MINUTE)) + ":" +
+                                                    String.format("%02d", it.timestamp.get(Calendar.SECOND))
                                         })
                                     }
                                 }
@@ -392,6 +402,25 @@ class MainFrameView {
     }
 
     void mvcGroupInit(Map<String, String> args) {
+
+        def mainFrame = builder.getVariable("main-frame")
+        mainFrame.setTransferHandler(new TransferHandler() {
+                    public boolean canImport(TransferHandler.TransferSupport support) {
+                        return support.isDataFlavorSupported(DataFlavor.javaFileListFlavor)
+                    }
+                    public boolean importData(TransferHandler.TransferSupport support) {
+                        def files = support.getTransferable().getTransferData(DataFlavor.javaFileListFlavor)
+                        files.each {
+                            if (it.isDirectory())
+                                watchDirectory(it)
+                            else
+                                model.core.eventBus.publish(new FileSharedEvent(file : it))
+                        }
+                        showUploadsWindow.call()
+                        true
+                    }
+                })
+
         def downloadsTable = builder.getVariable("downloads-table")
         def selectionModel = downloadsTable.getSelectionModel()
         selectionModel.setSelectionMode(ListSelectionModel.SINGLE_SELECTION)
@@ -407,7 +436,7 @@ class MainFrameView {
                 return
             }
             def downloader = model.downloads[selectedRow]?.downloader
-            if (downloader == null) 
+            if (downloader == null)
                 return
             model.downloader = downloader
             downloadDetailsPanel.getLayout().show(downloadDetailsPanel,"download-selected")
@@ -415,26 +444,26 @@ class MainFrameView {
                 case Downloader.DownloadState.CONNECTING :
                 case Downloader.DownloadState.DOWNLOADING :
                 case Downloader.DownloadState.HASHLIST:
-                model.cancelButtonEnabled = true
-                model.pauseButtonEnabled = true
-                model.retryButtonEnabled = false
-                break
+                    model.cancelButtonEnabled = true
+                    model.pauseButtonEnabled = true
+                    model.retryButtonEnabled = false
+                    break
                 case Downloader.DownloadState.FAILED:
-                model.cancelButtonEnabled = true
-                model.retryButtonEnabled = true
-                model.resumeButtonText = "Retry"
-                model.pauseButtonEnabled = false
-                break
+                    model.cancelButtonEnabled = true
+                    model.retryButtonEnabled = true
+                    model.resumeButtonText = "Retry"
+                    model.pauseButtonEnabled = false
+                    break
                 case Downloader.DownloadState.PAUSED:
-                model.cancelButtonEnabled = true
-                model.retryButtonEnabled = true
-                model.resumeButtonText = "Resume"
-                model.pauseButtonEnabled = false
-                break
+                    model.cancelButtonEnabled = true
+                    model.retryButtonEnabled = true
+                    model.resumeButtonText = "Resume"
+                    model.pauseButtonEnabled = false
+                    break
                 default:
-                model.cancelButtonEnabled = false
-                model.retryButtonEnabled = false
-                model.pauseButtonEnabled = false
+                    model.cancelButtonEnabled = false
+                    model.retryButtonEnabled = false
+                    model.pauseButtonEnabled = false
             }
         })
 
@@ -448,17 +477,17 @@ class MainFrameView {
         downloadsTable.rowSorter.setComparator(2, new DownloaderComparator())
 
         downloadsTable.addMouseListener(new MouseAdapter() {
-            @Override
-            public void mouseReleased(MouseEvent e) {
-                if (e.isPopupTrigger())
-                    showDownloadsMenu(e)
-            }
-            @Override
-            public void mousePressed(MouseEvent e) {
-                if (e.isPopupTrigger())
-                    showDownloadsMenu(e)
-            }
-        })
+                    @Override
+                    public void mouseReleased(MouseEvent e) {
+                        if (e.isPopupTrigger())
+                            showDownloadsMenu(e)
+                    }
+                    @Override
+                    public void mousePressed(MouseEvent e) {
+                        if (e.isPopupTrigger())
+                            showDownloadsMenu(e)
+                    }
+                })
 
         // shared files table
         def sharedFilesTable = builder.getVariable("shared-files-table")
@@ -474,17 +503,28 @@ class MainFrameView {
         JMenuItem unshareSelectedFiles = new JMenuItem("Unshare selected files")
         unshareSelectedFiles.addActionListener({mvcGroup.controller.unshareSelectedFile()})
         sharedFilesMenu.add(unshareSelectedFiles)
+        JMenuItem commentSelectedFiles = new JMenuItem("Comment selected files")
+        commentSelectedFiles.addActionListener({mvcGroup.controller.addComment()})
+        sharedFilesMenu.add(commentSelectedFiles)
         sharedFilesTable.addMouseListener(new MouseAdapter() {
-            @Override
-            public void mouseReleased(MouseEvent e) {
-                if (e.isPopupTrigger())
-                    showPopupMenu(sharedFilesMenu, e)
-            }
-            @Override
-            public void mousePressed(MouseEvent e) {
-                if (e.isPopupTrigger())
-                    showPopupMenu(sharedFilesMenu, e)
-            }
+                    @Override
+                    public void mouseReleased(MouseEvent e) {
+                        if (e.isPopupTrigger())
+                            showPopupMenu(sharedFilesMenu, e)
+                    }
+                    @Override
+                    public void mousePressed(MouseEvent e) {
+                        if (e.isPopupTrigger())
+                            showPopupMenu(sharedFilesMenu, e)
+                    }
+                })
+
+        selectionModel = sharedFilesTable.getSelectionModel()
+        selectionModel.addListSelectionListener({
+            def selectedFiles = selectedSharedFiles()
+            if (selectedFiles == null || selectedFiles.isEmpty())
+                return
+            model.addCommentButtonEnabled = true
         })
 
         // searches table
@@ -503,17 +543,17 @@ class MainFrameView {
         searchTableMenu.add(distrustSearcher)
 
         searchesTable.addMouseListener(new MouseAdapter() {
-            @Override
-            public void mouseReleased(MouseEvent e) {
-                if (e.isPopupTrigger())
-                    showPopupMenu(searchTableMenu, e)
-            }
-            @Override
-            public void mousePressed(MouseEvent e) {
-                if (e.isPopupTrigger())
-                    showPopupMenu(searchTableMenu, e)
-            }
-        })
+                    @Override
+                    public void mouseReleased(MouseEvent e) {
+                        if (e.isPopupTrigger())
+                            showPopupMenu(searchTableMenu, e)
+                    }
+                    @Override
+                    public void mousePressed(MouseEvent e) {
+                        if (e.isPopupTrigger())
+                            showPopupMenu(searchTableMenu, e)
+                    }
+                })
 
         // watched directories table
         def watchedTable = builder.getVariable("watched-directories-table")
@@ -524,17 +564,17 @@ class MainFrameView {
         stopWatching.addActionListener({mvcGroup.controller.stopWatchingDirectory()})
         watchedMenu.add(stopWatching)
         watchedTable.addMouseListener(new MouseAdapter() {
-            @Override
-            public void mouseReleased(MouseEvent e) {
-                if (e.isPopupTrigger())
-                    showPopupMenu(watchedMenu, e)
-            }
-            @Override
-            public void mousePressed(MouseEvent e) {
-                if (e.isPopupTrigger())
-                    showPopupMenu(watchedMenu, e)
-            }
-        })
+                    @Override
+                    public void mouseReleased(MouseEvent e) {
+                        if (e.isPopupTrigger())
+                            showPopupMenu(watchedMenu, e)
+                    }
+                    @Override
+                    public void mousePressed(MouseEvent e) {
+                        if (e.isPopupTrigger())
+                            showPopupMenu(watchedMenu, e)
+                    }
+                })
 
         // subscription table
         def subscriptionTable = builder.getVariable("subscription-table")
@@ -557,20 +597,20 @@ class MainFrameView {
             switch(trustList.status) {
                 case RemoteTrustList.Status.NEW:
                 case RemoteTrustList.Status.UPDATING:
-                model.reviewButtonEnabled = false
-                model.updateButtonEnabled = false
-                model.unsubscribeButtonEnabled = false
-                break
+                    model.reviewButtonEnabled = false
+                    model.updateButtonEnabled = false
+                    model.unsubscribeButtonEnabled = false
+                    break
                 case RemoteTrustList.Status.UPDATED:
-                model.reviewButtonEnabled = true
-                model.updateButtonEnabled = true
-                model.unsubscribeButtonEnabled = true
-                break
+                    model.reviewButtonEnabled = true
+                    model.updateButtonEnabled = true
+                    model.unsubscribeButtonEnabled = true
+                    break
                 case RemoteTrustList.Status.UPDATE_FAILED:
-                model.reviewButtonEnabled = false
-                model.updateButtonEnabled = true
-                model.unsubscribeButtonEnabled = true
-                break
+                    model.reviewButtonEnabled = false
+                    model.updateButtonEnabled = true
+                    model.unsubscribeButtonEnabled = true
+                    break
             }
         })
 
@@ -615,22 +655,36 @@ class MainFrameView {
         menu.show(event.getComponent(), event.getX(), event.getY())
     }
 
-    def selectedSharedFile() {
+    def selectedSharedFiles() {
         def sharedFilesTable = builder.getVariable("shared-files-table")
-        int selected = sharedFilesTable.getSelectedRow()
-        if (selected < 0)
+        int[] selected = sharedFilesTable.getSelectedRows()
+        if (selected.length == 0)
             return null
-        if (lastSharedSortEvent != null)
-            selected = sharedFilesTable.rowSorter.convertRowIndexToModel(selected)
-        model.shared[selected]
+        List<SharedFile> rv = new ArrayList<>()
+        if (lastSharedSortEvent != null) {
+            for (int i = 0; i < selected.length; i ++) {
+                selected[i] = sharedFilesTable.rowSorter.convertRowIndexToModel(selected[i])
+            }
+        }
+        selected.each {
+            rv.add(model.shared[it])
+        }
+        rv
     }
 
     def copyHashToClipboard() {
-        def selected = selectedSharedFile()
-        if (selected == null)
+        def selectedFiles = selectedSharedFiles()
+        if (selectedFiles == null)
             return
-        String root = Base64.encode(selected.infoHash.getRoot())
-        StringSelection selection = new StringSelection(root)
+        String roots = ""
+        for (Iterator<SharedFile> iterator = selectedFiles.iterator(); iterator.hasNext(); ) {
+            SharedFile selected = iterator.next()
+            String root = Base64.encode(selected.infoHash.getRoot())
+            roots += root
+            if (iterator.hasNext())
+                roots += "\n"
+        }
+        StringSelection selection = new StringSelection(roots)
         def clipboard = Toolkit.getDefaultToolkit().getSystemClipboard()
         clipboard.setContents(selection, null)
     }
@@ -726,7 +780,7 @@ class MainFrameView {
         model.monitorPaneButtonEnabled = true
         model.trustPaneButtonEnabled = true
     }
-    
+
     def showDownloadsWindow = {
         def cardsPanel = builder.getVariable("cards-panel")
         cardsPanel.getLayout().show(cardsPanel, "downloads window")
@@ -772,9 +826,12 @@ class MainFrameView {
         chooser.setFileHidingEnabled(false)
         chooser.setDialogTitle("Select file to share")
         chooser.setFileSelectionMode(JFileChooser.FILES_ONLY)
+        chooser.setMultiSelectionEnabled(true)
         int rv = chooser.showOpenDialog(null)
         if (rv == JFileChooser.APPROVE_OPTION) {
-            model.core.eventBus.publish(new FileSharedEvent(file : chooser.getSelectedFile()))
+            chooser.getSelectedFiles().each {
+                model.core.eventBus.publish(new FileSharedEvent(file : it))
+            }
         }
     }
 
@@ -783,17 +840,23 @@ class MainFrameView {
         chooser.setFileHidingEnabled(false)
         chooser.setDialogTitle("Select directory to watch")
         chooser.setFileSelectionMode(JFileChooser.DIRECTORIES_ONLY)
+        chooser.setMultiSelectionEnabled(true)
         int rv = chooser.showOpenDialog(null)
         if (rv == JFileChooser.APPROVE_OPTION) {
-            File f = chooser.getSelectedFile()
-            model.watched << f.getAbsolutePath()
-            application.context.get("muwire-settings").watchedDirectories << f.getAbsolutePath()
-            mvcGroup.controller.saveMuWireSettings()
-            builder.getVariable("watched-directories-table").model.fireTableDataChanged()
-            model.core.eventBus.publish(new FileSharedEvent(file : f))
+            chooser.getSelectedFiles().each { f ->
+                watchDirectory(f)
+            }
         }
     }
 
+    private void watchDirectory(File f) {
+        model.watched << f.getAbsolutePath()
+        application.context.get("muwire-settings").watchedDirectories << f.getAbsolutePath()
+        mvcGroup.controller.saveMuWireSettings()
+        builder.getVariable("watched-directories-table").model.fireTableDataChanged()
+        model.core.eventBus.publish(new FileSharedEvent(file : f))
+    }
+
     String getSelectedWatchedDirectory() {
         def watchedTable = builder.getVariable("watched-directories-table")
         int selectedRow = watchedTable.getSelectedRow()

gui/griffon-app/views/com/muwire/gui/OptionsView.groovy

@@ -55,6 +55,7 @@ class OptionsView {
     def outBwField
 
     def allowUntrustedCheckbox
+    def searchExtraHopCheckbox
     def allowTrustListsCheckbox
     def trustListIntervalField
 
@@ -70,7 +71,7 @@ class OptionsView {
             gridBagLayout()
             label(text : "Retry failed downloads every", constraints : gbc(gridx: 0, gridy: 0))
             retryField = textField(text : bind { model.downloadRetryInterval }, columns : 2, constraints : gbc(gridx: 1, gridy: 0))
-            label(text : "minutes", constraints : gbc(gridx : 2, gridy: 0))
+            label(text : "seconds", constraints : gbc(gridx : 2, gridy: 0))
 
             label(text : "Check for updates every", constraints : gbc(gridx : 0, gridy: 1))
             updateField = textField(text : bind {model.updateCheckInterval }, columns : 2, constraints : gbc(gridx : 1, gridy: 1))
@@ -138,11 +139,13 @@ class OptionsView {
             gridBagLayout()
             label(text : "Allow only trusted connections", constraints : gbc(gridx: 0, gridy : 0))
             allowUntrustedCheckbox = checkBox(selected : bind {model.onlyTrusted}, constraints : gbc(gridx: 1, gridy : 0))
-            label(text : "Allow others to view my trust list", constraints : gbc(gridx: 0, gridy : 1))
-            allowTrustListsCheckbox = checkBox(selected : bind {model.trustLists}, constraints : gbc(gridx: 1, gridy : 1))
-            label(text : "Update trust lists every ", constraints : gbc(gridx:0, gridy:2))
-            trustListIntervalField = textField(text : bind {model.trustListInterval}, constraints:gbc(gridx:1, gridy:2))
-            label(text : "hours", constraints : gbc(gridx: 2, gridy:2))
+            label(text : "Search extra hop", constraints : gbc(gridx:0, gridy:1))
+            searchExtraHopCheckbox = checkBox(selected : bind {model.searchExtraHop}, constraints : gbc(gridx: 1, gridy : 1))
+            label(text : "Allow others to view my trust list", constraints : gbc(gridx: 0, gridy : 2))
+            allowTrustListsCheckbox = checkBox(selected : bind {model.trustLists}, constraints : gbc(gridx: 1, gridy : 2))
+            label(text : "Update trust lists every ", constraints : gbc(gridx:0, gridy:3))
+            trustListIntervalField = textField(text : bind {model.trustListInterval}, constraints:gbc(gridx:1, gridy:3))
+            label(text : "hours", constraints : gbc(gridx: 2, gridy:3))
         }
 
 

gui/griffon-app/views/com/muwire/gui/SearchTabView.groovy

@@ -18,10 +18,13 @@ import javax.swing.SwingConstants
 import javax.swing.table.DefaultTableCellRenderer
 
 import com.muwire.core.Persona
+import com.muwire.core.search.UIResultEvent
 import com.muwire.core.util.DataUtil
 
 import java.awt.BorderLayout
 import java.awt.Color
+import java.awt.FlowLayout
+import java.awt.GridBagConstraints
 import java.awt.Toolkit
 import java.awt.datatransfer.StringSelection
 import java.awt.event.MouseAdapter
@@ -43,11 +46,13 @@ class SearchTabView {
     def lastSendersSortEvent
     def resultsTable
     def lastSortEvent
+    def sequentialDownloadCheckbox
 
     void initUI() {
         builder.with {
             def resultsTable
             def sendersTable
+            def sequentialDownloadCheckbox
             def pane = panel {
                 gridLayout(rows :1, cols : 1)
                 splitPane(orientation: JSplitPane.VERTICAL_SPLIT, continuousLayout : true, dividerLocation: 300 ) {
@@ -66,6 +71,7 @@ class SearchTabView {
                         }
                         panel(constraints : BorderLayout.SOUTH) {
                             button(text : "Trust", enabled: bind {model.trustButtonsEnabled }, trustAction)
+                            button(text : "Neutral", enabled: bind {model.trustButtonsEnabled}, neutralAction)
                             button(text : "Distrust", enabled : bind {model.trustButtonsEnabled}, distrustAction)
                         }
                     }
@@ -78,11 +84,22 @@ class SearchTabView {
                                     closureColumn(header: "Size", preferredWidth: 20, type: Long, read : {row -> row.size})
                                     closureColumn(header: "Direct Sources", preferredWidth: 50, type : Integer, read : { row -> model.hashBucket[row.infohash].size()})
                                     closureColumn(header: "Possible Sources", preferredWidth : 50, type : Integer, read : {row -> model.sourcesBucket[row.infohash].size()})
+                                    closureColumn(header: "Comments", preferredWidth: 20, type: Boolean, read : {row -> row.comment != null})
                                 }
                             }
                         }
                         panel(constraints : BorderLayout.SOUTH) {
-                            button(text : "Download", enabled : bind {model.downloadActionEnabled}, downloadAction)
+                            gridLayout(rows: 1, cols: 3)
+                            panel()
+                            panel {
+                                button(text : "Download", enabled : bind {model.downloadActionEnabled}, downloadAction)
+                            }
+                            panel {
+                                gridBagLayout()
+                                panel (constraints : gbc(gridx : 0, gridy : 0, weightx : 100))
+                                sequentialDownloadCheckbox = checkBox(constraints : gbc(gridx : 1, gridy: 0, weightx : 0),selected : false, enabled : bind {model.downloadActionEnabled})
+                                label(constraints: gbc(gridx: 2, gridy: 0, weightx : 0),text : "Download sequentially")
+                            }
                         }
                     }
                 }
@@ -94,18 +111,26 @@ class SearchTabView {
 
             this.resultsTable = resultsTable
             this.sendersTable = sendersTable
+            this.sequentialDownloadCheckbox = sequentialDownloadCheckbox
 
             def selectionModel = resultsTable.getSelectionModel()
-            selectionModel.setSelectionMode(ListSelectionModel.SINGLE_SELECTION)
+            selectionModel.setSelectionMode(ListSelectionModel.MULTIPLE_INTERVAL_SELECTION)
             selectionModel.addListSelectionListener( {
-                int row = resultsTable.getSelectedRow()
-                if (row < 0) {
+                int[] rows = resultsTable.getSelectedRows()
+                if (rows.length == 0) {
                     model.downloadActionEnabled = false
                     return
                 }
-                if (lastSortEvent != null)
-                    row = resultsTable.rowSorter.convertRowIndexToModel(row)
-                model.downloadActionEnabled = mvcGroup.parentGroup.model.canDownload(model.results[row].infohash)
+                if (lastSortEvent != null) {
+                    for (int i = 0; i < rows.length; i ++) {
+                        rows[i] = resultsTable.rowSorter.convertRowIndexToModel(rows[i])
+                    }
+                }
+                boolean downloadActionEnabled = true
+                rows.each { 
+                    downloadActionEnabled &= mvcGroup.parentGroup.model.canDownload(model.results[it].infohash)
+                }
+                model.downloadActionEnabled = downloadActionEnabled
             })
         }
     }
@@ -190,21 +215,38 @@ class SearchTabView {
 
     def showPopupMenu(MouseEvent e) {
         JPopupMenu menu = new JPopupMenu()
+        boolean showMenu = false
         if (model.downloadActionEnabled) {
             JMenuItem download = new JMenuItem("Download")
             download.addActionListener({mvcGroup.controller.download()})
             menu.add(download)
+            showMenu = true
         }
-        JMenuItem copyHashToClipboard = new JMenuItem("Copy hash to clipboard")
-        copyHashToClipboard.addActionListener({mvcGroup.view.copyHashToClipboard()})
-        menu.add(copyHashToClipboard)
-        menu.show(e.getComponent(), e.getX(), e.getY())
+        if (resultsTable.getSelectedRows().length == 1) {
+            JMenuItem copyHashToClipboard = new JMenuItem("Copy hash to clipboard")
+            copyHashToClipboard.addActionListener({mvcGroup.view.copyHashToClipboard()})
+            menu.add(copyHashToClipboard)
+            showMenu = true
+            
+            // show comment if any
+            int selectedRow = resultsTable.getSelectedRow()
+            if (lastSortEvent != null) 
+                selectedRow = resultsTable.rowSorter.convertRowIndexToModel(selectedRow)
+            if (model.results[selectedRow].comment != null) {
+                JMenuItem showComment = new JMenuItem("Show Comment")
+                showComment.addActionListener({mvcGroup.view.showComment()})
+                menu.add(showComment)
+            }
+        }
+        if (showMenu)
+            menu.show(e.getComponent(), e.getX(), e.getY())
     }
 
     def copyHashToClipboard() {
-        int selected = resultsTable.getSelectedRow()
-        if (selected < 0)
+        int[] selectedRows = resultsTable.getSelectedRows()
+        if (selectedRows.length != 1)
             return
+        int selected = selectedRows[0]
         if (lastSortEvent != null)
             selected = resultsTable.rowSorter.convertRowIndexToModel(selected)
         String hash = Base64.encode(model.results[selected].infohash.getRoot())
@@ -213,6 +255,23 @@ class SearchTabView {
         clipboard.setContents(selection, null)
     }
     
+    def showComment() {
+        int selectedRow = resultsTable.getSelectedRow()
+        if (selectedRow < 0)
+            return
+        if (lastSortEvent != null)
+            selectedRow = resultsTable.rowSorter.convertRowIndexToModel(selectedRow)
+        UIResultEvent event = model.results[selectedRow]
+        if (event.comment == null)
+            return
+            
+        String groupId = Base64.encode(event.infohash.getRoot())
+        Map<String,Object> params = new HashMap<>()
+        params['result'] = event
+        
+        mvcGroup.createMVCGroup("show-comment", groupId, params)
+    }
+    
     int selectedSenderRow() {
         int row = sendersTable.getSelectedRow()
         if (row < 0)

gui/griffon-app/views/com/muwire/gui/ShowCommentView.groovy

@@ -0,0 +1,61 @@
+package com.muwire.gui
+
+import griffon.core.artifact.GriffonView
+import griffon.inject.MVCMember
+import griffon.metadata.ArtifactProviderFor
+import net.i2p.data.Base64
+
+import javax.swing.JDialog
+import javax.swing.SwingConstants
+
+import com.muwire.core.util.DataUtil
+
+import java.awt.BorderLayout
+import java.awt.event.WindowAdapter
+import java.awt.event.WindowEvent
+
+import javax.annotation.Nonnull
+
+@ArtifactProviderFor(GriffonView)
+class ShowCommentView {
+    @MVCMember @Nonnull
+    FactoryBuilderSupport builder
+    @MVCMember @Nonnull
+    ShowCommentModel model
+
+    def mainFrame
+    def dialog
+    def p
+    
+    void initUI() {
+        mainFrame = application.windowManager.findWindow("main-frame")
+        dialog = new JDialog(mainFrame, model.result.name, true)
+        dialog.setResizable(true)
+        
+        
+        p = builder.panel {
+            borderLayout()
+            panel (constraints : BorderLayout.CENTER) {
+                scrollPane {
+                    textArea(text : model.result.comment, rows : 20, columns : 100, editable : false)
+                }
+            }
+            panel (constraints : BorderLayout.SOUTH) {
+                button(text : "Dismiss", dismissAction)
+            }
+        }
+    }
+    
+    void mvcGroupInit(Map<String,String> args) {
+        dialog.getContentPane().add(p)
+        dialog.pack()
+        dialog.setLocationRelativeTo(mainFrame)
+        dialog.setDefaultCloseOperation(JDialog.DISPOSE_ON_CLOSE)
+        dialog.addWindowListener( new WindowAdapter() {
+            public void windowClosed(WindowEvent e) {
+                mvcGroup.destroy()
+            }
+        })
+        dialog.show()
+    }
+}

gui/src/test/groovy/com/muwire/gui/ContentPanelControllerTest.groovy

@@ -1,21 +0,0 @@
-package com.muwire.gui
-
-import griffon.core.test.GriffonUnitRule
-import griffon.core.test.TestFor
-import org.junit.Rule
-import org.junit.Test
-
-import static org.junit.Assert.fail
-
-@TestFor(ContentPanelController)
-class ContentPanelControllerTest {
-    private ContentPanelController controller
-
-    @Rule
-    public final GriffonUnitRule griffon = new GriffonUnitRule()
-
-    @Test
-    void smokeTest() {
-        fail('Not yet implemented!')
-    }
-}

gui/src/test/groovy/com/muwire/gui/EventListControllerTest.groovy

@@ -1,21 +0,0 @@
-package com.muwire.gui
-
-import griffon.core.test.GriffonUnitRule
-import griffon.core.test.TestFor
-import org.junit.Rule
-import org.junit.Test
-
-import static org.junit.Assert.fail
-
-@TestFor(EventListController)
-class EventListControllerTest {
-    private EventListController controller
-
-    @Rule
-    public final GriffonUnitRule griffon = new GriffonUnitRule()
-
-    @Test
-    void smokeTest() {
-        fail('Not yet implemented!')
-    }
-}

gui/src/test/groovy/com/muwire/gui/I2PStatusControllerTest.groovy

@@ -1,21 +0,0 @@
-package com.muwire.gui
-
-import griffon.core.test.GriffonUnitRule
-import griffon.core.test.TestFor
-import org.junit.Rule
-import org.junit.Test
-
-import static org.junit.Assert.fail
-
-@TestFor(I2PStatusController)
-class I2PStatusControllerTest {
-    private I2PStatusController controller
-
-    @Rule
-    public final GriffonUnitRule griffon = new GriffonUnitRule()
-
-    @Test
-    void smokeTest() {
-        fail('Not yet implemented!')
-    }
-}

gui/src/test/groovy/com/muwire/gui/MainFrameControllerTest.groovy

@@ -1,21 +0,0 @@
-package com.muwire.gui
-
-import griffon.core.test.GriffonUnitRule
-import griffon.core.test.TestFor
-import org.junit.Rule
-import org.junit.Test
-
-import static org.junit.Assert.fail
-
-@TestFor(MainFrameController)
-class MainFrameControllerTest {
-    private MainFrameController controller
-
-    @Rule
-    public final GriffonUnitRule griffon = new GriffonUnitRule()
-
-    @Test
-    void smokeTest() {
-        fail('Not yet implemented!')
-    }
-}

gui/src/test/groovy/com/muwire/gui/MuWireStatusControllerTest.groovy

@@ -1,21 +0,0 @@
-package com.muwire.gui
-
-import griffon.core.test.GriffonUnitRule
-import griffon.core.test.TestFor
-import org.junit.Rule
-import org.junit.Test
-
-import static org.junit.Assert.fail
-
-@TestFor(MuWireStatusController)
-class MuWireStatusControllerTest {
-    private MuWireStatusController controller
-
-    @Rule
-    public final GriffonUnitRule griffon = new GriffonUnitRule()
-
-    @Test
-    void smokeTest() {
-        fail('Not yet implemented!')
-    }
-}

gui/src/test/groovy/com/muwire/gui/OptionsControllerTest.groovy

@@ -1,21 +0,0 @@
-package com.muwire.gui
-
-import griffon.core.test.GriffonUnitRule
-import griffon.core.test.TestFor
-import org.junit.Rule
-import org.junit.Test
-
-import static org.junit.Assert.fail
-
-@TestFor(OptionsController)
-class OptionsControllerTest {
-    private OptionsController controller
-
-    @Rule
-    public final GriffonUnitRule griffon = new GriffonUnitRule()
-
-    @Test
-    void smokeTest() {
-        fail('Not yet implemented!')
-    }
-}

gui/src/test/groovy/com/muwire/gui/SearchTabControllerTest.groovy

@@ -1,21 +0,0 @@
-package com.muwire.gui
-
-import griffon.core.test.GriffonUnitRule
-import griffon.core.test.TestFor
-import org.junit.Rule
-import org.junit.Test
-
-import static org.junit.Assert.fail
-
-@TestFor(SearchTabController)
-class SearchTabControllerTest {
-    private SearchTabController controller
-
-    @Rule
-    public final GriffonUnitRule griffon = new GriffonUnitRule()
-
-    @Test
-    void smokeTest() {
-        fail('Not yet implemented!')
-    }
-}

gui/src/test/groovy/com/muwire/gui/TrustListControllerTest.groovy

@@ -1,21 +0,0 @@
-package com.muwire.gui
-
-import griffon.core.test.GriffonUnitRule
-import griffon.core.test.TestFor
-import org.junit.Rule
-import org.junit.Test
-
-import static org.junit.Assert.fail
-
-@TestFor(TrustListController)
-class TrustListControllerTest {
-    private TrustListController controller
-
-    @Rule
-    public final GriffonUnitRule griffon = new GriffonUnitRule()
-
-    @Test
-    void smokeTest() {
-        fail('Not yet implemented!')
-    }
-}

host-cache/build.gradle

@@ -1,3 +1,8 @@
 apply plugin : 'application'
 mainClassName = 'com.muwire.hostcache.HostCache'
 applicationDefaultJvmArgs = ['-Djava.util.logging.config.file=logging.properties']
+
+dependencies {
+    testCompile 'org.junit.jupiter:junit-jupiter-api:5.4.2'
+    testCompile 'junit:junit:4.12'
+}